[2/2] gpio: x-gene: Remove a useless memset
diff mbox

Message ID 1430483346-10583-1-git-send-email-christophe.jaillet@wanadoo.fr
State New
Headers show

Commit Message

Christophe JAILLET May 1, 2015, 12:29 p.m. UTC
priv->irq is allocated using devm_kzalloc so there is no need to memset it.

Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
---
 drivers/gpio/gpio-xgene-sb.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dan Carpenter May 1, 2015, 2:19 p.m. UTC | #1
The "[PATCH 2/2]" bit is a mistake.  It's not part of a patchset.  It's
just that you have sent two patches today.  The first patch wasn't even
named [1/2]...

Unless, it is part of a patchset??  If so where is the first patch?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christophe JAILLET May 1, 2015, 2:54 p.m. UTC | #2
Hi,

yes, you are correct, it's a mistake.
Should I resubmit with an updated subject?

CJ


Le 01/05/2015 16:19, Dan Carpenter a écrit :
> The "[PATCH 2/2]" bit is a mistake.  It's not part of a patchset.  It's
> just that you have sent two patches today.  The first patch wasn't even
> named [1/2]...
>
> Unless, it is part of a patchset??  If so where is the first patch?
>
> regards,
> dan carpenter
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dan Carpenter May 1, 2015, 3:44 p.m. UTC | #3
On Fri, May 01, 2015 at 04:54:28PM +0200, Marion & Christophe JAILLET wrote:
> Hi,
> 
> yes, you are correct, it's a mistake.
> Should I resubmit with an updated subject?

No.

Also don't top post etc etc.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij May 12, 2015, 7:43 a.m. UTC | #4
On Fri, May 1, 2015 at 2:29 PM, Christophe Jaillet
<christophe.jaillet@wanadoo.fr> wrote:

> priv->irq is allocated using devm_kzalloc so there is no need to memset it.
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c
index fb9d29a..a7b8f8f 100644
--- a/drivers/gpio/gpio-xgene-sb.c
+++ b/drivers/gpio/gpio-xgene-sb.c
@@ -112,7 +112,6 @@  static int xgene_gpio_sb_probe(struct platform_device *pdev)
 				   GFP_KERNEL);
 	if (!priv->irq)
 		return -ENOMEM;
-	memset(priv->irq, 0, sizeof(u32) * XGENE_MAX_GPIO_DS);
 
 	for (i = 0; i < priv->nirq; i++) {
 		priv->irq[default_lines[i]] = platform_get_irq(pdev, i);