Patchwork Enable enhanced functions for 8536 TSEC

login
register
mail settings
Submitter Jason Jin
Date Oct. 16, 2008, 9:31 a.m.
Message ID <1224149492-11204-1-git-send-email-Jason.jin@freescale.com>
Download mbox | patch
Permalink /patch/4669/
State Accepted, archived
Commit ba556ed23c73796efd58ac348cc33773935bb3b9
Delegated to: Kumar Gala
Headers show

Comments

Jason Jin - Oct. 16, 2008, 9:31 a.m.
Signed-off-by: Jason Jin <Jason.jin@freescale.com>
---
 arch/powerpc/boot/dts/mpc8536ds.dts |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Kumar Gala - Oct. 20, 2008, 2:46 p.m.
On Oct 16, 2008, at 4:31 AM, Jason Jin wrote:

> Signed-off-by: Jason Jin <Jason.jin@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8536ds.dts |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

applied

- k
Benjamin Herrenschmidt - Oct. 20, 2008, 11:54 p.m.
On Thu, 2008-10-16 at 17:31 +0800, Jason Jin wrote:
> Signed-off-by: Jason Jin <Jason.jin@freescale.com>
> ---
>  arch/powerpc/boot/dts/mpc8536ds.dts |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8536ds.dts b/arch/powerpc/boot/dts/mpc8536ds.dts
> index 93fdd99..dce2f65 100644
> --- a/arch/powerpc/boot/dts/mpc8536ds.dts
> +++ b/arch/powerpc/boot/dts/mpc8536ds.dts
> @@ -180,7 +180,7 @@
>  		enet0: ethernet@24000 {
>  			cell-index = <0>;
>  			device_type = "network";
> -			model = "TSEC";
> +			model = "eTSEC";
>  			compatible = "gianfar";
>  			reg = <0x24000 0x1000>;
>  			local-mac-address = [ 00 00 00 00 00 00 ];

While this works, this isn't quite "proper" use of the device-tree,
you should instead have something like

compatible="gianfar-eTSEC","gianfar" or something like that

Cheers,
Ben.

Patch

diff --git a/arch/powerpc/boot/dts/mpc8536ds.dts b/arch/powerpc/boot/dts/mpc8536ds.dts
index 93fdd99..dce2f65 100644
--- a/arch/powerpc/boot/dts/mpc8536ds.dts
+++ b/arch/powerpc/boot/dts/mpc8536ds.dts
@@ -180,7 +180,7 @@ 
 		enet0: ethernet@24000 {
 			cell-index = <0>;
 			device_type = "network";
-			model = "TSEC";
+			model = "eTSEC";
 			compatible = "gianfar";
 			reg = <0x24000 0x1000>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
@@ -193,7 +193,7 @@ 
 		enet1: ethernet@26000 {
 			cell-index = <1>;
 			device_type = "network";
-			model = "TSEC";
+			model = "eTSEC";
 			compatible = "gianfar";
 			reg = <0x26000 0x1000>;
 			local-mac-address = [ 00 00 00 00 00 00 ];