From patchwork Tue Mar 2 18:29:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 46674 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F2193B7D19 for ; Wed, 3 Mar 2010 05:29:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144Ab0CBS31 (ORCPT ); Tue, 2 Mar 2010 13:29:27 -0500 Received: from mail.dev.rtsoft.ru ([213.79.90.226]:38714 "HELO mail.dev.rtsoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751927Ab0CBS31 (ORCPT ); Tue, 2 Mar 2010 13:29:27 -0500 Received: (qmail 8563 invoked from network); 2 Mar 2010 18:29:32 -0000 Received: from unknown (HELO localhost) (192.168.1.70) by 0 with SMTP; 2 Mar 2010 18:29:32 -0000 Date: Tue, 2 Mar 2010 21:29:25 +0300 From: Anton Vorontsov To: Jeff Garzik Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/12] ahci: Fix some sparse warnings Message-ID: <20100302182925.GA3445@oksana.dev.rtsoft.ru> References: <20100302182850.GA32057@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100302182850.GA32057@oksana.dev.rtsoft.ru> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Following warnings were fixed: ahci.c:359:1: warning: symbol 'dev_attr_ahci_host_caps' was not declared. Should it be static? ahci.c:360:1: warning: symbol 'dev_attr_ahci_host_cap2' was not declared. Should it be static? ahci.c:361:1: warning: symbol 'dev_attr_ahci_host_version' was not declared. Should it be static? ahci.c:362:1: warning: symbol 'dev_attr_ahci_port_cmd' was not declared. Should it be static? This was left over: ahci.c:382:9: warning: Initializer entry defined twice ahci.c:383:10: also defined here Signed-off-by: Anton Vorontsov --- drivers/ata/ahci.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index a6a736a..ef7949a 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -356,10 +356,10 @@ static ssize_t ahci_show_host_version(struct device *dev, static ssize_t ahci_show_port_cmd(struct device *dev, struct device_attribute *attr, char *buf); -DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL); -DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL); -DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL); -DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL); +static DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL); +static DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL); +static DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL); +static DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL); static struct device_attribute *ahci_shost_attrs[] = { &dev_attr_link_power_management_policy,