Patchwork configure: Fix wrong stderr redirection

login
register
mail settings
Submitter Stefan Weil
Date March 1, 2010, 9:10 p.m.
Message ID <1267477846-6168-1-git-send-email-weil@mail.berlios.de>
Download mbox | patch
Permalink /patch/46606/
State New
Headers show

Comments

Stefan Weil - March 1, 2010, 9:10 p.m.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 configure |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Juan Quintela - March 3, 2010, 6:29 p.m.
Stefan Weil <weil@mail.berlios.de> wrote:
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Ouch.  good catch.

Acked-by: Juan Quintela <quintela@redhat.com>

> ---
>  configure |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index dfe3e42..a14aba7 100755
> --- a/configure
> +++ b/configure
> @@ -1091,8 +1091,8 @@ EOF
>      # static link with sdl ? (note: sdl.pc's --static --libs is broken)
>      if test "$sdl" = "yes" -a "$static" = "yes" ; then
>        if test $? = 0 && echo $sdl_libs | grep -- -laa > /dev/null; then
> -         sdl_libs="$sdl_libs `aalib-config --static-libs >2 /dev/null`"
> -         sdl_cflags="$sdl_cflags `aalib-config --cflags >2 /dev/null`"
> +         sdl_libs="$sdl_libs `aalib-config --static-libs 2>/dev/null`"
> +         sdl_cflags="$sdl_cflags `aalib-config --cflags 2>/dev/null`"
>        fi
>        if compile_prog "$sdl_cflags" "$sdl_libs" ; then
>  	:
Anthony Liguori - March 9, 2010, 5:21 p.m.
On 03/01/2010 03:10 PM, Stefan Weil wrote:
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>    


Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   configure |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index dfe3e42..a14aba7 100755
> --- a/configure
> +++ b/configure
> @@ -1091,8 +1091,8 @@ EOF
>       # static link with sdl ? (note: sdl.pc's --static --libs is broken)
>       if test "$sdl" = "yes" -a "$static" = "yes" ; then
>         if test $? = 0&&  echo $sdl_libs | grep -- -laa>  /dev/null; then
> -         sdl_libs="$sdl_libs `aalib-config --static-libs>2 /dev/null`"
> -         sdl_cflags="$sdl_cflags `aalib-config --cflags>2 /dev/null`"
> +         sdl_libs="$sdl_libs `aalib-config --static-libs 2>/dev/null`"
> +         sdl_cflags="$sdl_cflags `aalib-config --cflags 2>/dev/null`"
>         fi
>         if compile_prog "$sdl_cflags" "$sdl_libs" ; then
>   	:
>

Patch

diff --git a/configure b/configure
index dfe3e42..a14aba7 100755
--- a/configure
+++ b/configure
@@ -1091,8 +1091,8 @@  EOF
     # static link with sdl ? (note: sdl.pc's --static --libs is broken)
     if test "$sdl" = "yes" -a "$static" = "yes" ; then
       if test $? = 0 && echo $sdl_libs | grep -- -laa > /dev/null; then
-         sdl_libs="$sdl_libs `aalib-config --static-libs >2 /dev/null`"
-         sdl_cflags="$sdl_cflags `aalib-config --cflags >2 /dev/null`"
+         sdl_libs="$sdl_libs `aalib-config --static-libs 2>/dev/null`"
+         sdl_cflags="$sdl_cflags `aalib-config --cflags 2>/dev/null`"
       fi
       if compile_prog "$sdl_cflags" "$sdl_libs" ; then
 	: