From patchwork Thu Oct 16 06:08:12 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 4660 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 671C5DDF5E for ; Thu, 16 Oct 2008 17:18:54 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org X-Greylist: delayed 629 seconds by postgrey-1.31 at ozlabs; Thu, 16 Oct 2008 17:18:34 EST Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by ozlabs.org (Postfix) with ESMTP id 165DDDDF02 for ; Thu, 16 Oct 2008 17:18:33 +1100 (EST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 15 Oct 2008 23:08:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.33,422,1220252400"; d="scan'208";a="60649210" Received: from dwillia2-linux.ch.intel.com (HELO [10.2.42.224]) ([10.2.42.224]) by azsmga001.ch.intel.com with ESMTP; 15 Oct 2008 23:07:42 -0700 Subject: Re: powerpc allmodconfig From: Dan Williams To: David Miller In-Reply-To: <20081015.220247.262683261.davem@davemloft.net> References: <20081015213337.a99a9595.akpm@linux-foundation.org> <20081015.220247.262683261.davem@davemloft.net> Date: Wed, 15 Oct 2008 23:08:12 -0700 Message-Id: <1224137292.26782.5.camel@dwillia2-linux.ch.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-5.fc8) Cc: bzolnier@gmail.com, marek.vasut@gmail.com, tiwai@suse.de, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, mark.fasheh@oracle.com, linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org, brice@myri.com, jesse.brandeburg@intel.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, dwmw2@infradead.org, mchehab@infradead.org X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote: > > drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios': > > drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax' > > drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled': > > drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has' > > drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function) > > drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once > > drivers/dma/ioat_dca.c:91: error: for each function it appears in.) > > drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag': > > drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id' > > Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in > order to fix this, but he hasn't shown any signs of life. > > So I'll do it myself later tonight. :-/ > The following seems to fix this up... ---snip---> ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y From: Dan Williams The INTEL_IOATDMA symbol depends on x86. 'select' ignores this dependency. Cc: Brice Goglin Cc: Jesse Brandeburg Signed-off-by: Dan Williams --- drivers/net/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 1d8af33..84983f8 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2410,7 +2410,7 @@ config IXGBE tristate "Intel(R) 10GbE PCI Express adapters support" depends on PCI && INET select INET_LRO - select INTEL_IOATDMA + select INTEL_IOATDMA if X86 ---help--- This driver supports Intel(R) 10GbE PCI Express family of adapters. For more information on how to identify your adapter, go @@ -2462,7 +2462,7 @@ config MYRI10GE select FW_LOADER select CRC32 select INET_LRO - select INTEL_IOATDMA + select INTEL_IOATDMA if X86 ---help--- This driver supports Myricom Myri-10G Dual Protocol interface in Ethernet mode. If the eeprom on your board is not recent enough,