diff mbox

[U-Boot,v2,4/4] x86: fsp: Use reset_cpu()

Message ID 1430273492-10784-4-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass April 29, 2015, 2:11 a.m. UTC 
Now that reset_cpu() functions correctly, use it instead of directly
accessing the port on boards that use a Firmware Support Package (FSP).

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 arch/x86/lib/fsp/fsp_common.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Simon Glass April 30, 2015, 4:21 a.m. UTC | #1 
On 28 April 2015 at 20:11, Simon Glass <sjg@chromium.org> wrote:
> Now that reset_cpu() functions correctly, use it instead of directly
> accessing the port on boards that use a Firmware Support Package (FSP).
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/lib/fsp/fsp_common.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/arch/x86/lib/fsp/fsp_common.c b/arch/x86/lib/fsp/fsp_common.c
> index f668259..001494d 100644
> --- a/arch/x86/lib/fsp/fsp_common.c
> +++ b/arch/x86/lib/fsp/fsp_common.c
> @@ -17,13 +17,6 @@ int print_cpuinfo(void)
>         return default_print_cpuinfo();
>  }
>
> -void reset_cpu(ulong addr)
> -{
> -       /* cold reset */
> -       outb(0x06, PORT_RESET);
> -}
> -
> -
>  int board_pci_post_scan(struct pci_controller *hose)
>  {
>         u32 status;
> --
> 2.2.0.rc0.207.ga3a616c
>

Applied to u-boot-x86.
diff mbox

Patch

diff --git a/arch/x86/lib/fsp/fsp_common.c b/arch/x86/lib/fsp/fsp_common.c
index f668259..001494d 100644
--- a/arch/x86/lib/fsp/fsp_common.c
+++ b/arch/x86/lib/fsp/fsp_common.c
@@ -17,13 +17,6 @@  int print_cpuinfo(void)
 	return default_print_cpuinfo();
 }
 
-void reset_cpu(ulong addr)
-{
-	/* cold reset */
-	outb(0x06, PORT_RESET);
-}
-
-
 int board_pci_post_scan(struct pci_controller *hose)
 {
 	u32 status;