Patchwork [1/1] drm/i915: don't change DRM configuration when releasing load detect pipe

mail settings
Submitter Chase Douglas
Date March 1, 2010, 4:37 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/46566/
State Accepted
Delegated to: Andy Whitcroft
Headers show


Chase Douglas - March 1, 2010, 4:37 p.m.
From: Jesse Barnes <>

When we get a CRTC to use for load detection, we restore its DPMS state
if needed.  We shouldn't, however, change the DRM configuration by
calling drm_helper_disable_unused_functions when we release the CRTC.
Doing so can cause problems with resume, since at suspend or lid close
time, X may choose to probe outputs.  If it doesn't re-probe them at
open or resume time, LVDS won't be restored, since
drm_helper_disable_unused_functions will have turned it off, preventing
the mode set at lid open from restoring it.

Fixes kernel bz #14997.


Cc: stable at
Tested-by: Takashi Iwai <tiwai at>
Tested-by: Thorsten Leemhuis <fedora at>
Signed-off-by: Jesse Barnes <jbarnes at>
Signed-off-by: Chase Douglas <>
 drivers/gpu/drm/i915/intel_display.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b00a1aa..0e4af08 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3619,7 +3619,6 @@  struct drm_crtc *intel_get_load_detect_pipe(struct intel_output *intel_output,
 void intel_release_load_detect_pipe(struct intel_output *intel_output, int dpms_mode)
 	struct drm_encoder *encoder = &intel_output->enc;
-	struct drm_device *dev = encoder->dev;
 	struct drm_crtc *crtc = encoder->crtc;
 	struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
 	struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
@@ -3629,7 +3628,6 @@  void intel_release_load_detect_pipe(struct intel_output *intel_output, int dpms_
 		intel_output->base.encoder = NULL;
 		intel_output->load_detect_temp = false;
 		crtc->enabled = drm_helper_crtc_in_use(crtc);
-		drm_helper_disable_unused_functions(dev);
 	/* Switch crtc and output back off if necessary */