Message ID | 1267448966.3039.22.camel@edumazet-laptop |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Eric Dumazet wrote: > [PATCH] net: fix protocol sk_buff field > > Commit e992cd9b72a18 (kmemcheck: make bitfield annotations truly no-ops > when disabled) allows us to revert a workaround we did in the past to > not add holes in sk_buff structure. > > This patch partially reverts commit 14d18a81b5171 > (net: fix kmemcheck annotations) so that sparse doesnt complain: > > include/linux/skbuff.h:357:41: error: invalid bitfield specifier for > type restricted __be16. Great, very appreciated.
From: Stefan Richter <stefanr@s5r6.in-berlin.de> Date: Mon, 01 Mar 2010 17:18:06 +0100 > Eric Dumazet wrote: >> [PATCH] net: fix protocol sk_buff field >> >> Commit e992cd9b72a18 (kmemcheck: make bitfield annotations truly no-ops >> when disabled) allows us to revert a workaround we did in the past to >> not add holes in sk_buff structure. >> >> This patch partially reverts commit 14d18a81b5171 >> (net: fix kmemcheck annotations) so that sparse doesnt complain: >> >> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for >> type restricted __be16. > > Great, very appreciated. Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index ae836fd..b40f56b 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -354,8 +354,8 @@ struct sk_buff { ipvs_property:1, peeked:1, nf_trace:1; - __be16 protocol:16; kmemcheck_bitfield_end(flags1); + __be16 protocol; void (*destructor)(struct sk_buff *skb); #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)