Patchwork [2/6] input/mc13783-ts: Don't use deprecated mc13783 API calls

login
register
mail settings
Submitter Uwe Kleine-König
Date March 1, 2010, 10:53 a.m.
Message ID <1267440825-14694-2-git-send-email-u.kleine-koenig@pengutronix.de>
Download mbox | patch
Permalink /patch/46534/
State New
Headers show

Comments

Uwe Kleine-König - March 1, 2010, 10:53 a.m.
mc13783_ackirq is deprecated, use the drop in replacement mc13783_irq_ack.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

note this obviously depends on patch 1/6.

Best regards
Uwe

 drivers/input/touchscreen/mc13783_ts.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Dmitry Torokhov - March 2, 2010, 7:55 a.m.
On Mon, Mar 01, 2010 at 11:53:41AM +0100, Uwe Kleine-König wrote:
> mc13783_ackirq is deprecated, use the drop in replacement mc13783_irq_ack.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

I assume it will go thourgh MFD tree?

Acked-by: Dmitry Torokhov <dtor@mail.ru>

> ---
> Hello,
> 
> note this obviously depends on patch 1/6.
> 
> Best regards
> Uwe
> 
>  drivers/input/touchscreen/mc13783_ts.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c
> index be115b3..be54fd6 100644
> --- a/drivers/input/touchscreen/mc13783_ts.c
> +++ b/drivers/input/touchscreen/mc13783_ts.c
> @@ -44,7 +44,7 @@ static irqreturn_t mc13783_ts_handler(int irq, void *data)
>  {
>  	struct mc13783_ts_priv *priv = data;
>  
> -	mc13783_ackirq(priv->mc13783, irq);
> +	mc13783_irq_ack(priv->mc13783, irq);
>  
>  	/*
>  	 * Kick off reading coordinates. Note that if work happens already
> @@ -135,7 +135,7 @@ static int mc13783_ts_open(struct input_dev *dev)
>  
>  	mc13783_lock(priv->mc13783);
>  
> -	mc13783_ackirq(priv->mc13783, MC13783_IRQ_TS);
> +	mc13783_irq_ack(priv->mc13783, MC13783_IRQ_TS);
>  
>  	ret = mc13783_irq_request(priv->mc13783, MC13783_IRQ_TS,
>  		mc13783_ts_handler, MC13783_TS_NAME, priv);
> -- 
> 1.7.0
>
Uwe Kleine-König - March 2, 2010, 8:54 a.m.
On Mon, Mar 01, 2010 at 11:55:13PM -0800, Dmitry Torokhov wrote:
> On Mon, Mar 01, 2010 at 11:53:41AM +0100, Uwe Kleine-König wrote:
> > mc13783_ackirq is deprecated, use the drop in replacement mc13783_irq_ack.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> I assume it will go thourgh MFD tree?
I don't know.  I would have suggest to let it go via Andrew[1] as the
biggest changes in this series are rtc related and these usually go via
him.  But MFD would be OK for me, too.

Best regards
Uwe

[1] hmm, forgot to Cc: him.  This is done now.

Patch

diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c
index be115b3..be54fd6 100644
--- a/drivers/input/touchscreen/mc13783_ts.c
+++ b/drivers/input/touchscreen/mc13783_ts.c
@@ -44,7 +44,7 @@  static irqreturn_t mc13783_ts_handler(int irq, void *data)
 {
 	struct mc13783_ts_priv *priv = data;
 
-	mc13783_ackirq(priv->mc13783, irq);
+	mc13783_irq_ack(priv->mc13783, irq);
 
 	/*
 	 * Kick off reading coordinates. Note that if work happens already
@@ -135,7 +135,7 @@  static int mc13783_ts_open(struct input_dev *dev)
 
 	mc13783_lock(priv->mc13783);
 
-	mc13783_ackirq(priv->mc13783, MC13783_IRQ_TS);
+	mc13783_irq_ack(priv->mc13783, MC13783_IRQ_TS);
 
 	ret = mc13783_irq_request(priv->mc13783, MC13783_IRQ_TS,
 		mc13783_ts_handler, MC13783_TS_NAME, priv);