| Message ID | 1430157509-9486-1-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
Am 27.04.2015 um 19:58 schrieb Eduardo Habkost: > The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: > > Open 2.4 development tree (2015-04-25 22:05:07 +0100) > > are available in the git repository at: > > git://github.com/ehabkost/qemu.git tags/x86-pull-request > > for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188: > > target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300) > > ---------------------------------------------------------------- > X86 queue, 2015-04-27 > > ---------------------------------------------------------------- > > Eduardo Habkost (6): > MAINTAINERS: Add myself to X86 > MAINTAINERS: Change status of X86 to Maintained > qemu-config: Accept empty option values > target-i386: Make "level" and "xlevel" properties static Small objection. Andreas > target-i386: X86CPU::xlevel2 QOM property > target-i386: Remove AMD feature flag aliases from CPU model table > > MAINTAINERS | 3 ++- > target-i386/cpu.c | 50 ++++---------------------------------------------- > util/qemu-config.c | 4 +++- > 3 files changed, 9 insertions(+), 48 deletions(-) >
Am 27.04.2015 um 20:17 schrieb Andreas Färber: > Am 27.04.2015 um 19:58 schrieb Eduardo Habkost: >> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: >> >> Open 2.4 development tree (2015-04-25 22:05:07 +0100) >> >> are available in the git repository at: >> >> git://github.com/ehabkost/qemu.git tags/x86-pull-request >> >> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188: >> >> target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300) >> >> ---------------------------------------------------------------- >> X86 queue, 2015-04-27 >> >> ---------------------------------------------------------------- >> >> Eduardo Habkost (6): >> MAINTAINERS: Add myself to X86 >> MAINTAINERS: Change status of X86 to Maintained >> qemu-config: Accept empty option values >> target-i386: Make "level" and "xlevel" properties static > > Small objection. Also, I'm missing my PC unref refactoring in your pull? > > Andreas > >> target-i386: X86CPU::xlevel2 QOM property >> target-i386: Remove AMD feature flag aliases from CPU model table >> >> MAINTAINERS | 3 ++- >> target-i386/cpu.c | 50 ++++---------------------------------------------- >> util/qemu-config.c | 4 +++- >> 3 files changed, 9 insertions(+), 48 deletions(-)
On Mon, Apr 27, 2015 at 08:25:20PM +0200, Andreas Färber wrote: > Am 27.04.2015 um 20:17 schrieb Andreas Färber: > > Am 27.04.2015 um 19:58 schrieb Eduardo Habkost: > >> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: > >> > >> Open 2.4 development tree (2015-04-25 22:05:07 +0100) > >> > >> are available in the git repository at: > >> > >> git://github.com/ehabkost/qemu.git tags/x86-pull-request > >> > >> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188: > >> > >> target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300) > >> > >> ---------------------------------------------------------------- > >> X86 queue, 2015-04-27 > >> > >> ---------------------------------------------------------------- > >> > >> Eduardo Habkost (6): > >> MAINTAINERS: Add myself to X86 > >> MAINTAINERS: Change status of X86 to Maintained > >> qemu-config: Accept empty option values > >> target-i386: Make "level" and "xlevel" properties static > > > > Small objection. > > Also, I'm missing my PC unref refactoring in your pull? I hadn't reviewed it completely (then got distracted by other tasks and forgot about it), sorry. I added a reminder to review it to my todo-list, so you can get my Reviewed-by soon. I assume Michael is OK with having it going through the x86 tree, even if it touches only pc.c.
On Mon, Apr 27, 2015 at 03:37:53PM -0300, Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 08:25:20PM +0200, Andreas Färber wrote: > > Am 27.04.2015 um 20:17 schrieb Andreas Färber: > > > Am 27.04.2015 um 19:58 schrieb Eduardo Habkost: > > >> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: > > >> > > >> Open 2.4 development tree (2015-04-25 22:05:07 +0100) > > >> > > >> are available in the git repository at: > > >> > > >> git://github.com/ehabkost/qemu.git tags/x86-pull-request > > >> > > >> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188: > > >> > > >> target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300) > > >> > > >> ---------------------------------------------------------------- > > >> X86 queue, 2015-04-27 > > >> > > >> ---------------------------------------------------------------- > > >> > > >> Eduardo Habkost (6): > > >> MAINTAINERS: Add myself to X86 > > >> MAINTAINERS: Change status of X86 to Maintained > > >> qemu-config: Accept empty option values > > >> target-i386: Make "level" and "xlevel" properties static > > > > > > Small objection. > > > > Also, I'm missing my PC unref refactoring in your pull? > > I hadn't reviewed it completely (then got distracted by other tasks and > forgot about it), sorry. I added a reminder to review it to my > todo-list, so you can get my Reviewed-by soon. > > I assume Michael is OK with having it going through the x86 tree, even > if it touches only pc.c. I don't know which patches these are, sorry. Was I Cc'd? > -- > Eduardo
On Mon, Apr 27, 2015 at 08:54:24PM +0200, Michael S. Tsirkin wrote: > On Mon, Apr 27, 2015 at 03:37:53PM -0300, Eduardo Habkost wrote: > > On Mon, Apr 27, 2015 at 08:25:20PM +0200, Andreas Färber wrote: > > > Am 27.04.2015 um 20:17 schrieb Andreas Färber: > > > > Am 27.04.2015 um 19:58 schrieb Eduardo Habkost: > > > >> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: > > > >> > > > >> Open 2.4 development tree (2015-04-25 22:05:07 +0100) > > > >> > > > >> are available in the git repository at: > > > >> > > > >> git://github.com/ehabkost/qemu.git tags/x86-pull-request > > > >> > > > >> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188: > > > >> > > > >> target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300) > > > >> > > > >> ---------------------------------------------------------------- > > > >> X86 queue, 2015-04-27 > > > >> > > > >> ---------------------------------------------------------------- > > > >> > > > >> Eduardo Habkost (6): > > > >> MAINTAINERS: Add myself to X86 > > > >> MAINTAINERS: Change status of X86 to Maintained > > > >> qemu-config: Accept empty option values > > > >> target-i386: Make "level" and "xlevel" properties static > > > > > > > > Small objection. > > > > > > Also, I'm missing my PC unref refactoring in your pull? > > > > I hadn't reviewed it completely (then got distracted by other tasks and > > forgot about it), sorry. I added a reminder to review it to my > > todo-list, so you can get my Reviewed-by soon. > > > > I assume Michael is OK with having it going through the x86 tree, even > > if it touches only pc.c. > > I don't know which patches these are, sorry. > Was I Cc'd? Yes: Date: Tue, 17 Mar 2015 17:46:36 +0100 From: Andreas Färber <afaerber@suse.de> Subject: [Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count after attaching to ICC bus To: qemu-devel@nongnu.org Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, "Michael S. Tsirkin" <mst@redhat.com>, ehabkost@redhat.com, Andreas Färber <afaerber@suse.de>