Patchwork Fix curses return key when using -k

login
register
mail settings
Submitter Samuel Thibault
Date Feb. 28, 2010, 2:35 p.m.
Message ID <20100228143519.GM11637@const.famille.thibault.fr>
Download mbox | patch
Permalink /patch/46502/
State New
Headers show

Comments

Samuel Thibault - Feb. 28, 2010, 2:35 p.m.
Hello,

There is a small incoherency in curses_keys.h, which makes it fail to
emit \n when using e.g. -k fr: curses2keysym transforms \r and 0x157
into \n, but name2keysym binds \r with Return, not \n.  The patch below
fixes that.

Samuel
Samuel Thibault - Feb. 28, 2010, 5:06 p.m.
Samuel Thibault, le Sun 28 Feb 2010 15:35:19 +0100, a écrit :
> There is a small incoherency in curses_keys.h, which makes it fail to
> emit \n when using e.g. -k fr: curses2keysym transforms \r and 0x157
> into \n, but name2keysym binds \r with Return, not \n.  The patch below
> fixes that.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> Samuel
> 
> diff --git a/curses_keys.h b/curses_keys.h
> index a6e41cf..6030720 100644
> --- a/curses_keys.h
> +++ b/curses_keys.h
> @@ -446,7 +446,7 @@ static const name2keysym_t name2keysym[] = {
>      /* Special keys */
>      { "BackSpace", 0x07f },
>      { "Tab", '\t' },
> -    { "Return", '\r' },
> +    { "Return", '\n' },
>      { "Right", 0x105 },
>      { "Left", 0x104 },
>      { "Up", 0x103 },
andrzej zaborowski - March 2, 2010, 11:16 p.m.
On 28 February 2010 15:35, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Hello,
>
> There is a small incoherency in curses_keys.h, which makes it fail to
> emit \n when using e.g. -k fr: curses2keysym transforms \r and 0x157
> into \n, but name2keysym binds \r with Return, not \n.  The patch below
> fixes that.

Thanks, applied both patches.

Cheers

Patch

diff --git a/curses_keys.h b/curses_keys.h
index a6e41cf..6030720 100644
--- a/curses_keys.h
+++ b/curses_keys.h
@@ -446,7 +446,7 @@  static const name2keysym_t name2keysym[] = {
     /* Special keys */
     { "BackSpace", 0x07f },
     { "Tab", '\t' },
-    { "Return", '\r' },
+    { "Return", '\n' },
     { "Right", 0x105 },
     { "Left", 0x104 },
     { "Up", 0x103 },