From patchwork Sun Feb 28 08:03:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roy Tam X-Patchwork-Id: 46484 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 19727B7D04 for ; Sun, 28 Feb 2010 19:08:24 +1100 (EST) Received: from localhost ([127.0.0.1]:33500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NleCK-0004qK-E2 for incoming@patchwork.ozlabs.org; Sun, 28 Feb 2010 03:08:20 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nle8X-0004gE-CN for qemu-devel@nongnu.org; Sun, 28 Feb 2010 03:04:25 -0500 Received: from [199.232.76.173] (port=46200 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nle8T-0004ff-Hr for qemu-devel@nongnu.org; Sun, 28 Feb 2010 03:04:22 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nle8S-0001of-Hs for qemu-devel@nongnu.org; Sun, 28 Feb 2010 03:04:20 -0500 Received: from mail-px0-f203.google.com ([209.85.216.203]:46432) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nle8S-0001oJ-9Q for qemu-devel@nongnu.org; Sun, 28 Feb 2010 03:04:20 -0500 Received: by pxi41 with SMTP id 41so499767pxi.23 for ; Sun, 28 Feb 2010 00:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=uNTNuBPeqw/A3x+obGTjlO5O6QH5DNVhHmvCQSZ+q5w=; b=iWmajQ9QIzvrqhBSsYGdrTF9f03H1L9znm1Ks2ksJMjs/RyCP1pMsZpVOE/U/7abcS mB2BTNYkHgULwyaSousILOGpIBJMZftjJutj4scM7tA9tNejIY8wXAg+JUfP4QP6ulHK dsjqghYxQTaEhQkz9nYVZMfok8VTXSOVdBOCM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=aJNlFAKr82HO+nXHnjBoarMdV61FkPRr8MviuJAkAELdra8lzyqHoTTX4edB94m47a RFeoR/kLvNr2WozXvoQAyYMaQnMY2IuyS4IT0thHjSGnwKG2kuu9LPMhM3RM1RWfemD7 vANOSl8NMrTT5T7ix8wa55yfQ7/5lnDKCq9yY= MIME-Version: 1.0 Received: by 10.114.248.27 with SMTP id v27mr1581175wah.227.1267344258171; Sun, 28 Feb 2010 00:04:18 -0800 (PST) From: Roy Tam Date: Sun, 28 Feb 2010 16:03:58 +0800 Message-ID: <473191351002280003y34b9f473m27db1fea2cec1bb8@mail.gmail.com> To: qemu-devel X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH] Serial: DOS Plus regression X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents booting Digital Research DOSPlus. Following patch partially reverts that commit and makes DOSPlus booting in QEMU again. Sign-off-by: Roy Tam --- case 2: diff --git a/hw/serial.c b/hw/serial.c index df67383..cf23aad 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque, uint32_t addr, uint32_t val) s->poll_msl = 0; } } - if (s->lsr & UART_LSR_THRE) { - s->thr_ipending = 1; - serial_update_irq(s); - } } break;