Patchwork Serial: DOS Plus regression

login
register
mail settings
Submitter Roy Tam
Date Feb. 28, 2010, 8:03 a.m.
Message ID <473191351002280003y34b9f473m27db1fea2cec1bb8@mail.gmail.com>
Download mbox | patch
Permalink /patch/46484/
State New
Headers show

Comments

Roy Tam - Feb. 28, 2010, 8:03 a.m.
The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
booting Digital Research DOSPlus. Following patch partially reverts
that commit and makes DOSPlus booting in QEMU again.

Sign-off-by: Roy Tam <roytam@gmail.com>

--

     case 2:
Anthony Liguori - March 9, 2010, 3:05 p.m.
On 02/28/2010 02:03 AM, Roy Tam wrote:
> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
> booting Digital Research DOSPlus. Following patch partially reverts
> that commit and makes DOSPlus booting in QEMU again.
>
> Sign-off-by: Roy Tam<roytam@gmail.com>
>
> --
>
> diff --git a/hw/serial.c b/hw/serial.c
> index df67383..cf23aad 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
> uint32_t addr, uint32_t val)
>    

This patch is whitespace damaged.

Regards,

Anthony Liguori

>                        s->poll_msl = 0;
>                   }
>               }
> -            if (s->lsr&  UART_LSR_THRE) {
> -                s->thr_ipending = 1;
> -                serial_update_irq(s);
> -            }
>           }
>           break;
>       case 2:
>
>
>
>
Roy Tam - March 9, 2010, 3:39 p.m.
2010/3/9 Anthony Liguori <anthony@codemonkey.ws>
>
> On 02/28/2010 02:03 AM, Roy Tam wrote:
>>
>> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
>> booting Digital Research DOSPlus. Following patch partially reverts
>> that commit and makes DOSPlus booting in QEMU again.
>>
>> Sign-off-by: Roy Tam<roytam@gmail.com>
>>
>> --
>>
>> diff --git a/hw/serial.c b/hw/serial.c
>> index df67383..cf23aad 100644
>> --- a/hw/serial.c
>> +++ b/hw/serial.c
>> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
>> uint32_t addr, uint32_t val)
>>
>
> This patch is whitespace damaged.
>
> Regards,
>
> Anthony Liguori
>

GMail wrapped the mail. Sorry about that.
Patch file attached.

Patch

diff --git a/hw/serial.c b/hw/serial.c
index df67383..cf23aad 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -401,10 +401,6 @@  static void serial_ioport_write(void *opaque,
uint32_t addr, uint32_t val)
                      s->poll_msl = 0;
                 }
             }
-            if (s->lsr & UART_LSR_THRE) {
-                s->thr_ipending = 1;
-                serial_update_irq(s);
-            }
         }
         break;