diff mbox

[U-Boot,v2,3/4] sunxi: emac: Rename DMA_CPU_TRRESHOLD to EMAC_RX_BUFSIZE

Message ID 1429962708-12065-4-git-send-email-hdegoede@redhat.com
State Accepted
Delegated to: Hans de Goede
Headers show

Commit Message

Hans de Goede April 25, 2015, 11:51 a.m. UTC 
Besides being spelled wron, the DMA_CPU_TRRESHOLD define actually has
nothing to do with DMA as we only use mmio fifo access. Rename it to
EMAC_RX_BUFSIZE to properly reflect what it does.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/net/sunxi_emac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass April 25, 2015, 3:41 p.m. UTC | #1 
On 25 April 2015 at 05:51, Hans de Goede <hdegoede@redhat.com> wrote:
> Besides being spelled wron, the DMA_CPU_TRRESHOLD define actually has

:-)

> nothing to do with DMA as we only use mmio fifo access. Rename it to
> EMAC_RX_BUFSIZE to properly reflect what it does.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/net/sunxi_emac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/drivers/net/sunxi_emac.c b/drivers/net/sunxi_emac.c
> index 038f474..e43b1e7 100644
> --- a/drivers/net/sunxi_emac.c
> +++ b/drivers/net/sunxi_emac.c
> @@ -153,7 +153,7 @@ struct sunxi_sramc_regs {
>  #define EMAC_CRCERR            (0x1 << 4)
>  #define EMAC_LENERR            (0x3 << 5)
>
> -#define DMA_CPU_TRRESHOLD      2000
> +#define EMAC_RX_BUFSIZE                2000
>
>  struct emac_eth_dev {
>         struct emac_regs *regs;
> @@ -455,7 +455,7 @@ static int _sunxi_emac_eth_recv(struct emac_eth_dev *priv, void *packet)
>
>         /* Move data from EMAC */
>         if (good_packet) {
> -               if (rx_len > DMA_CPU_TRRESHOLD) {
> +               if (rx_len > EMAC_RX_BUFSIZE) {
>                         printf("Received packet is too big (len=%d)\n", rx_len);
>                         return -EMSGSIZE;
>                 }
> --
> 2.3.5
>
diff mbox

Patch

diff --git a/drivers/net/sunxi_emac.c b/drivers/net/sunxi_emac.c
index 038f474..e43b1e7 100644
--- a/drivers/net/sunxi_emac.c
+++ b/drivers/net/sunxi_emac.c
@@ -153,7 +153,7 @@  struct sunxi_sramc_regs {
 #define EMAC_CRCERR		(0x1 << 4)
 #define EMAC_LENERR		(0x3 << 5)
 
-#define DMA_CPU_TRRESHOLD	2000
+#define EMAC_RX_BUFSIZE		2000
 
 struct emac_eth_dev {
 	struct emac_regs *regs;
@@ -455,7 +455,7 @@  static int _sunxi_emac_eth_recv(struct emac_eth_dev *priv, void *packet)
 
 	/* Move data from EMAC */
 	if (good_packet) {
-		if (rx_len > DMA_CPU_TRRESHOLD) {
+		if (rx_len > EMAC_RX_BUFSIZE) {
 			printf("Received packet is too big (len=%d)\n", rx_len);
 			return -EMSGSIZE;
 		}