| Message ID | 553A8046.7080709@siemens.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Apr 24, 2015 at 10:41 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > The subtle difference between "property not found" and "property not > set" is already confusing enough. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > backends/hostmem-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c > index 5179994..4b55361 100644 > --- a/backends/hostmem-file.c > +++ b/backends/hostmem-file.c > @@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) > return; > } > if (!fb->mem_path) { > - error_setg(errp, "mem_path property not set"); > + error_setg(errp, "mem-path property not set"); > return; > } > #ifndef CONFIG_LINUX > -- > 2.1.4 >
24.04.2015 20:41, Jan Kiszka wrote: > The subtle difference between "property not found" and "property not > set" is already confusing enough. Applied to -trivial, thanks! /mjt
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c index 5179994..4b55361 100644 --- a/backends/hostmem-file.c +++ b/backends/hostmem-file.c @@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) return; } if (!fb->mem_path) { - error_setg(errp, "mem_path property not set"); + error_setg(errp, "mem-path property not set"); return; } #ifndef CONFIG_LINUX
The subtle difference between "property not found" and "property not set" is already confusing enough. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- backends/hostmem-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)