diff mbox

[30/30] package/matchbox-panel: fix WiFi monitoring

Message ID 3de1b4334c76469f95d791d578f769831ab2f3a5.1429725549.git.yann.morin.1998@free.fr
State Changes Requested
Headers show

Commit Message

Yann E. MORIN April 22, 2015, 6:09 p.m. UTC
matchbox-panel can build a simple applet to monitor the WiFi. For that,
it tries to see if libiwl is available; if so, WiFi monitoring is
enabled, otherwise it is disabled; there is not option to explicitly
enable or disable it.

Currently, matchbox-panel depends on the wireless-tools package.
However, that's not enough, since the library will only be installed if
explictly enabled in the menuconfig *and* this is not a static build.

Change the dependency to be on the library, not the package.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/matchbox/matchbox-panel/matchbox-panel.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnout Vandecappelle May 1, 2015, 9:45 p.m. UTC | #1
On 22/04/15 20:09, Yann E. MORIN wrote:
> matchbox-panel can build a simple applet to monitor the WiFi. For that,
> it tries to see if libiwl is available; if so, WiFi monitoring is
> enabled, otherwise it is disabled; there is not option to explicitly
> enable or disable it.
> 
> Currently, matchbox-panel depends on the wireless-tools package.
> However, that's not enough, since the library will only be installed if
> explictly enabled in the menuconfig *and* this is not a static build.
  explicitly

> 
> Change the dependency to be on the library, not the package.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> ---
>  package/matchbox/matchbox-panel/matchbox-panel.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/matchbox/matchbox-panel/matchbox-panel.mk b/package/matchbox/matchbox-panel/matchbox-panel.mk
> index dedbab6..455ae34 100644
> --- a/package/matchbox/matchbox-panel/matchbox-panel.mk
> +++ b/package/matchbox/matchbox-panel/matchbox-panel.mk
> @@ -32,7 +32,7 @@ else
>  MATCHBOX_PANEL_CONF_OPTS += --disable-dnotify
>  endif
>  
> -ifeq ($(BR2_PACKAGE_WIRELESS_TOOLS),y)
> +ifeq ($(BR2_PACKAGE_WIRELESS_TOOLS_LIB),y)
>  MATCHBOX_PANEL_DEPENDENCIES += wireless_tools
>  endif
>  
>
diff mbox

Patch

diff --git a/package/matchbox/matchbox-panel/matchbox-panel.mk b/package/matchbox/matchbox-panel/matchbox-panel.mk
index dedbab6..455ae34 100644
--- a/package/matchbox/matchbox-panel/matchbox-panel.mk
+++ b/package/matchbox/matchbox-panel/matchbox-panel.mk
@@ -32,7 +32,7 @@  else
 MATCHBOX_PANEL_CONF_OPTS += --disable-dnotify
 endif
 
-ifeq ($(BR2_PACKAGE_WIRELESS_TOOLS),y)
+ifeq ($(BR2_PACKAGE_WIRELESS_TOOLS_LIB),y)
 MATCHBOX_PANEL_DEPENDENCIES += wireless_tools
 endif