| Message ID | 71ea29cc98ad7d3f0278f14b50837784776b12ca.1429725549.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
On 04/22/15 20:09, Yann E. MORIN wrote: > Now that the matchbox package no longer forcibly add entries to the > PACKAGES list, and entirely relies on having proper packages, we can > safely include all matchbox sub-packages .mk files, and the pkg-infra > will take care of building only those that are enabled. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> This could already been done after patches 1 and 2. Regards, Arnout > --- > package/matchbox/matchbox.mk | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/package/matchbox/matchbox.mk b/package/matchbox/matchbox.mk > index 17d89d8..ae989b3 100644 > --- a/package/matchbox/matchbox.mk > +++ b/package/matchbox/matchbox.mk > @@ -1,3 +1 @@ > -ifeq ($(BR2_PACKAGE_MATCHBOX),y) > include $(sort $(wildcard package/matchbox/*/*.mk)) > -endif >
Arnout, All, On 2015-04-24 00:01 +0200, Arnout Vandecappelle spake thusly: > On 04/22/15 20:09, Yann E. MORIN wrote: > > Now that the matchbox package no longer forcibly add entries to the > > PACKAGES list, and entirely relies on having proper packages, we can > > safely include all matchbox sub-packages .mk files, and the pkg-infra > > will take care of building only those that are enabled. > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > This could already been done after patches 1 and 2. It might be possible to do so, but I'd prefer all matchbox packages to be converted/cleaned-up first, in case there's an unwanted side-effect in the package infra about a package with no Kconfig entry. So, I'm not moving that patch (also due to some lazyness in testing there would be no problem! ;-] ). Thanks! Regards, Yann E. MORIN.
diff --git a/package/matchbox/matchbox.mk b/package/matchbox/matchbox.mk index 17d89d8..ae989b3 100644 --- a/package/matchbox/matchbox.mk +++ b/package/matchbox/matchbox.mk @@ -1,3 +1 @@ -ifeq ($(BR2_PACKAGE_MATCHBOX),y) include $(sort $(wildcard package/matchbox/*/*.mk)) -endif
Now that the matchbox package no longer forcibly add entries to the PACKAGES list, and entirely relies on having proper packages, we can safely include all matchbox sub-packages .mk files, and the pkg-infra will take care of building only those that are enabled. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/matchbox/matchbox.mk | 2 -- 1 file changed, 2 deletions(-)