| Message ID | 40921cd751a3d6dc2bca91cb2ad74001733f6931.1429725549.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
On 04/22/15 20:09, Yann E. MORIN wrote: > Currently, matchbox-desktop is treated as if it were an option of the > matchbox package. > > But that's not true, since it is a real package all by itself, with its > own archive and its own buildsystem. > > So, make it a real package. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> One remark below... > --- > package/matchbox/Config.in | 7 +------ > package/matchbox/matchbox-desktop/Config.in | 5 +++++ > 2 files changed, 6 insertions(+), 6 deletions(-) > create mode 100644 package/matchbox/matchbox-desktop/Config.in > > diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in > index e791cea..39aff3c 100644 > --- a/package/matchbox/Config.in > +++ b/package/matchbox/Config.in > @@ -22,12 +22,7 @@ if BR2_PACKAGE_MATCHBOX > source "package/matchbox/matchbox-lib/Config.in" > source "package/matchbox/matchbox-wm/Config.in" > source "package/matchbox/matchbox-panel/Config.in" > - > -config BR2_PACKAGE_MATCHBOX_DESKTOP > - bool "Matchbox Desktop" > - select BR2_PACKAGE_ZLIB > - help > - A PDA style application launcher or 'item browser'. > +source "package/matchbox/matchbox-desktop/Config.in" Note that things should be sorted alphabetically. But I think that can better be combined with the one-directory-up patch. Regards, Arnout > > config BR2_PACKAGE_MATCHBOX_COMMON > bool "Matchbox session common files" > diff --git a/package/matchbox/matchbox-desktop/Config.in b/package/matchbox/matchbox-desktop/Config.in > new file mode 100644 > index 0000000..c9fd196 > --- /dev/null > +++ b/package/matchbox/matchbox-desktop/Config.in > @@ -0,0 +1,5 @@ > +config BR2_PACKAGE_MATCHBOX_DESKTOP > + bool "Matchbox Desktop" > + select BR2_PACKAGE_ZLIB > + help > + A PDA style application launcher or 'item browser'. >
Arnout, All, On 2015-04-23 23:49 +0200, Arnout Vandecappelle spake thusly: > On 04/22/15 20:09, Yann E. MORIN wrote: > > Currently, matchbox-desktop is treated as if it were an option of the > > matchbox package. > > > > But that's not true, since it is a real package all by itself, with its > > own archive and its own buildsystem. > > > > So, make it a real package. > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > One remark below... > > > --- > > package/matchbox/Config.in | 7 +------ > > package/matchbox/matchbox-desktop/Config.in | 5 +++++ > > 2 files changed, 6 insertions(+), 6 deletions(-) > > create mode 100644 package/matchbox/matchbox-desktop/Config.in > > > > diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in > > index e791cea..39aff3c 100644 > > --- a/package/matchbox/Config.in > > +++ b/package/matchbox/Config.in > > @@ -22,12 +22,7 @@ if BR2_PACKAGE_MATCHBOX > > source "package/matchbox/matchbox-lib/Config.in" > > source "package/matchbox/matchbox-wm/Config.in" > > source "package/matchbox/matchbox-panel/Config.in" > > - > > -config BR2_PACKAGE_MATCHBOX_DESKTOP > > - bool "Matchbox Desktop" > > - select BR2_PACKAGE_ZLIB > > - help > > - A PDA style application launcher or 'item browser'. > > +source "package/matchbox/matchbox-desktop/Config.in" > > Note that things should be sorted alphabetically. But I think that can better > be combined with the one-directory-up patch. Yup, done. Regards, Yann E. MORIN.
diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in index e791cea..39aff3c 100644 --- a/package/matchbox/Config.in +++ b/package/matchbox/Config.in @@ -22,12 +22,7 @@ if BR2_PACKAGE_MATCHBOX source "package/matchbox/matchbox-lib/Config.in" source "package/matchbox/matchbox-wm/Config.in" source "package/matchbox/matchbox-panel/Config.in" - -config BR2_PACKAGE_MATCHBOX_DESKTOP - bool "Matchbox Desktop" - select BR2_PACKAGE_ZLIB - help - A PDA style application launcher or 'item browser'. +source "package/matchbox/matchbox-desktop/Config.in" config BR2_PACKAGE_MATCHBOX_COMMON bool "Matchbox session common files" diff --git a/package/matchbox/matchbox-desktop/Config.in b/package/matchbox/matchbox-desktop/Config.in new file mode 100644 index 0000000..c9fd196 --- /dev/null +++ b/package/matchbox/matchbox-desktop/Config.in @@ -0,0 +1,5 @@ +config BR2_PACKAGE_MATCHBOX_DESKTOP + bool "Matchbox Desktop" + select BR2_PACKAGE_ZLIB + help + A PDA style application launcher or 'item browser'.
Currently, matchbox-desktop is treated as if it were an option of the matchbox package. But that's not true, since it is a real package all by itself, with its own archive and its own buildsystem. So, make it a real package. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/matchbox/Config.in | 7 +------ package/matchbox/matchbox-desktop/Config.in | 5 +++++ 2 files changed, 6 insertions(+), 6 deletions(-) create mode 100644 package/matchbox/matchbox-desktop/Config.in