[OpenWrt-Devel,v2] ncm: add support to run via proto wwan
diff mbox

Message ID CAC-0c8eNzvsuJDn=u_UMP2qkOcSqinb9u410hds7KhZqOkC9+A@mail.gmail.com
State Changes Requested
Headers show

Commit Message

Aleksandr Kolesnik April 22, 2015, 1:26 p.m. UTC
Signed-off-by: Aleksandr Kolesnik <neryba@gmail.com>

Comments

John Crispin July 7, 2015, 12:03 p.m. UTC | #1
Hi,

patch is generated against the wrong root folder. also your mail client
replaced tabs with spaces. please fix and resend the patch

	John

On 22/04/2015 15:26, Aleksandr Kolesnik wrote:
> Signed-off-by: Aleksandr Kolesnik <neryba@gmail.com
> <mailto:neryba@gmail.com>>
> 
> --- package/network/utils/comgt/files/ncm.sh
> +++ package/network/utils/comgt/files/ncm.sh
> @@ -27,6 +27,8 @@ proto_ncm_setup() {
>  local device apn auth username password pincode delay mode
>  json_get_vars device apn auth username password pincode delay mode
>  
> +[ -n "$ctl_device" ] && device=$ctl_device
> +
>  [ -n "$device" ] || {
>  echo "No control device specified"
>  proto_notify_error "$interface" NO_DEVICE
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>

Patch
diff mbox

--- package/network/utils/comgt/files/ncm.sh
+++ package/network/utils/comgt/files/ncm.sh
@@ -27,6 +27,8 @@  proto_ncm_setup() {
  local device apn auth username password pincode delay mode
  json_get_vars device apn auth username password pincode delay mode

+ [ -n "$ctl_device" ] && device=$ctl_device
+
  [ -n "$device" ] || {
  echo "No control device specified"
  proto_notify_error "$interface" NO_DEVICE