From patchwork Fri Feb 26 20:04:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahar Havivi X-Patchwork-Id: 46362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 20D4AB7D03 for ; Sat, 27 Feb 2010 07:10:55 +1100 (EST) Received: from localhost ([127.0.0.1]:51701 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nl6WS-0001wc-U2 for incoming@patchwork.ozlabs.org; Fri, 26 Feb 2010 15:10:53 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nl6QE-00083U-6Q for qemu-devel@nongnu.org; Fri, 26 Feb 2010 15:04:26 -0500 Received: from [199.232.76.173] (port=52287 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nl6QD-00083C-OT for qemu-devel@nongnu.org; Fri, 26 Feb 2010 15:04:25 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nl6QC-000136-FW for qemu-devel@nongnu.org; Fri, 26 Feb 2010 15:04:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40595) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nl6QC-00012y-3S for qemu-devel@nongnu.org; Fri, 26 Feb 2010 15:04:24 -0500 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QK4NpO022413 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Feb 2010 15:04:23 -0500 Received: from localhost (dhcp-1-229.tlv.redhat.com [10.35.1.229]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1QK4LqN024410; Fri, 26 Feb 2010 15:04:22 -0500 Date: Fri, 26 Feb 2010 22:04:14 +0200 From: Shahar Havivi To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor Message-ID: <20100226200414.GA25277@redhat.com> References: <20100226093456.GA17347@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100226093456.GA17347@redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Dor Laor X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Fix codding style --- qemu-char.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) -- 1.6.3.3 diff --git a/qemu-char.c b/qemu-char.c index 4169492..4533887 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, speed, parity, data_bits, stop_bits); #endif tcgetattr (fd, &tty); + oldtty = tty; #define check_speed(val) if (speed <= val) { spd = B##val; break; } speed = speed * 10 / 11; @@ -1173,6 +1174,11 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg) return 0; } +static void tty_exit(void) +{ + tcsetattr(0, TCSANOW, &oldtty); +} + static void qemu_chr_close_tty(CharDriverState *chr) { FDCharDriver *s = chr->opaque; @@ -1207,6 +1213,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) } chr->chr_ioctl = tty_serial_ioctl; chr->chr_close = qemu_chr_close_tty; + if (!term_atexit_done++) { + atexit(tty_exit); + } return chr; } #else /* ! __linux__ && ! __sun__ */