| Message ID | 1429623359-32618-1-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On 21 April 2015 at 07:35, Linus Walleij <linus.walleij@linaro.org> wrote: > This assignment conflicts with code that add flags with > gd->flags |= FOO prior to the execution of this function. > Seems like a historical artifact and creates bugs with > early alloc(). > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > board/armltd/integrator/integrator.c | 2 -- > 1 file changed, 2 deletions(-) Acked-by: Simon Glass <sjg@chromium.org>
On Tue, Apr 21, 2015 at 03:35:59PM +0200, Linus Walleij wrote: > This assignment conflicts with code that add flags with > gd->flags |= FOO prior to the execution of this function. > Seems like a historical artifact and creates bugs with > early alloc(). > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c index f0fe0fd3aabe..e94ac850c751 100644 --- a/board/armltd/integrator/integrator.c +++ b/board/armltd/integrator/integrator.c @@ -54,8 +54,6 @@ int board_init (void) /* adress of boot parameters */ gd->bd->bi_boot_params = 0x00000100; - gd->flags = 0; - #ifdef CONFIG_CM_REMAP extern void cm_remap(void); cm_remap(); /* remaps writeable memory to 0x00000000 */
This assignment conflicts with code that add flags with gd->flags |= FOO prior to the execution of this function. Seems like a historical artifact and creates bugs with early alloc(). Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- board/armltd/integrator/integrator.c | 2 -- 1 file changed, 2 deletions(-)