diff mbox

Skip preprocessor directives in mklog

Message ID 553633FB.3050206@samsung.com
State New
Headers show

Commit Message

Yury Gribov April 21, 2015, 11:26 a.m. UTC 
Hi all,

Contrib/mklog is currently faked by preprocessor directives inside 
functions to produce invalid ChangeLog.  The attached patch fixes this.

Tested with my local mklog testsuite and http://paste.debian.net/167999/ 
.  Ok to commit?

-Y

Comments

Yury Gribov April 30, 2015, 9:03 a.m. UTC | #1 
On 04/21/2015 02:26 PM, Yury Gribov wrote:
> Hi all,
>
> Contrib/mklog is currently faked by preprocessor directives inside
> functions to produce invalid ChangeLog.  The attached patch fixes this.
>
> Tested with my local mklog testsuite and http://paste.debian.net/167999/
> .  Ok to commit?
diff mbox

Patch

commit 23a738d05393676e72db82cb527d5fb1b3060e2f
Author: Yury Gribov <y.gribov@samsung.com>
Date:   Tue Apr 21 14:17:23 2015 +0300

    2015-04-21  Yury Gribov  <y.gribov@samsung.com>
    
    	* mklog: Ignore preprocessor directives.

diff --git a/contrib/mklog b/contrib/mklog
index f7974a7..455614b 100755
--- a/contrib/mklog
+++ b/contrib/mklog
@@ -131,7 +131,6 @@  sub is_unified_hunk_start {
 }
 
 # Check if line is a top-level declaration.
-# TODO: ignore preprocessor directives except maybe #define ?
 sub is_top_level {
 	my ($function, $is_context_diff) = (@_);
 	if (is_unified_hunk_start ($function)
@@ -143,7 +142,7 @@  sub is_top_level {
 	} else {
 		$function =~ s/^.//;
 	}
-	return $function && $function !~ /^[\s{]/;
+	return $function && $function !~ /^[\s{#]/;
 }
 
 # Read contents of .diff file