| Message ID | 1429553273-6453-14-git-send-email-p.marczak@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On 20 April 2015 at 12:07, Przemyslaw Marczak <p.marczak@samsung.com> wrote: > In the power_init_board function call, regulator driver init is called, > so before compile, make sure that any power framework is defined. > > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> > --- > board/samsung/common/board.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Simon Glass <sjg@chromium.org> Would be good to sort the includes correctly (unrelated to your patch).
On 22 April 2015 at 10:31, Simon Glass <sjg@chromium.org> wrote: > On 20 April 2015 at 12:07, Przemyslaw Marczak <p.marczak@samsung.com> wrote: >> In the power_init_board function call, regulator driver init is called, >> so before compile, make sure that any power framework is defined. >> >> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> >> --- >> board/samsung/common/board.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Simon Glass <sjg@chromium.org> > > Would be good to sort the includes correctly (unrelated to your patch). Applied to u-boot-dm/next, thanks!
Hello, On 04/22/2015 06:31 PM, Simon Glass wrote: > On 20 April 2015 at 12:07, Przemyslaw Marczak <p.marczak@samsung.com> wrote: >> In the power_init_board function call, regulator driver init is called, >> so before compile, make sure that any power framework is defined. >> >> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> >> --- >> board/samsung/common/board.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Simon Glass <sjg@chromium.org> > > Would be good to sort the includes correctly (unrelated to your patch). > Ok, will do that. Best regards,
diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c index 9be2950..20dd75c 100644 --- a/board/samsung/common/board.c +++ b/board/samsung/common/board.c @@ -21,9 +21,9 @@ #include <asm/arch/pinmux.h> #include <asm/arch/power.h> #include <asm/arch/system.h> -#include <power/pmic.h> #include <asm/arch/sromc.h> #include <lcd.h> +#include <i2c.h> #include <samsung/misc.h> #include <usb.h> @@ -169,7 +169,7 @@ int board_early_init_f(void) } #endif -#if defined(CONFIG_POWER) +#if defined(CONFIG_POWER) || defined(CONFIG_DM_PMIC) int power_init_board(void) { set_ps_hold_ctrl();
In the power_init_board function call, regulator driver init is called, so before compile, make sure that any power framework is defined. Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> --- board/samsung/common/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)