[1/1] heimdal: needs host-flex and explicitly set -lpthread

Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
---
 package/heimdal/heimdal.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Dear Ryan Coe,

On Sun, 19 Apr 2015 10:53:23 -0700, Ryan Coe wrote:
> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
> ---
>  package/heimdal/heimdal.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk
> index 972f15c..c4a1703 100644
> --- a/package/heimdal/heimdal.mk
> +++ b/package/heimdal/heimdal.mk
> @@ -6,11 +6,11 @@
>  
>  HEIMDAL_VERSION = 1.5.3
>  HEIMDAL_SITE = http://www.h5l.org/dist/src
> -HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf
> +HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex
>  HEIMDAL_INSTALL_STAGING = YES
>  # static because of -fPIC issues with e2fsprogs on x86_64 host
>  HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static
> -HOST_HEIMDAL_CONF_ENV = MAKEINFO=true
> +HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread"

Could you give more details about the situations in which you are
seeing problems with host-flex and -lpthread being missing?

I indeed see that flex and bison are being tested at configure time,
but failing to detect them does not seem to affect the build (maybe
heimdal has a pre-generated versions of the files normally generated by
flex/bison?). And I see -lpthread being used properly when linking.

So, please include more details about the issues you're seeing your
commit log.

Thanks a lot!

Thomas

On 04/20/2015 01:35 PM, Thomas Petazzoni wrote:
> Dear Ryan Coe,
>
> On Sun, 19 Apr 2015 10:53:23 -0700, Ryan Coe wrote:
>> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
>> ---
>>   package/heimdal/heimdal.mk | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk
>> index 972f15c..c4a1703 100644
>> --- a/package/heimdal/heimdal.mk
>> +++ b/package/heimdal/heimdal.mk
>> @@ -6,11 +6,11 @@
>>   
>>   HEIMDAL_VERSION = 1.5.3
>>   HEIMDAL_SITE = http://www.h5l.org/dist/src
>> -HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf
>> +HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex
>>   HEIMDAL_INSTALL_STAGING = YES
>>   # static because of -fPIC issues with e2fsprogs on x86_64 host
>>   HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static
>> -HOST_HEIMDAL_CONF_ENV = MAKEINFO=true
>> +HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread"
> Could you give more details about the situations in which you are
> seeing problems with host-flex and -lpthread being missing?
>
> I indeed see that flex and bison are being tested at configure time,
> but failing to detect them does not seem to affect the build (maybe
> heimdal has a pre-generated versions of the files normally generated by
> flex/bison?). And I see -lpthread being used properly when linking.
>
> So, please include more details about the issues you're seeing your
> commit log.
>
> Thanks a lot!
>
> Thomas
Thomas,

I found the addition of host-flex not to be necessary.  The -lpthread 
addition fixes a build error on my machine.  I will submit a new version 
of my patch.

Thanks,
Ryan

Dear Ryan Coe,

On Mon, 20 Apr 2015 19:03:10 -0700, Ryan Coe wrote:

> I found the addition of host-flex not to be necessary.  The -lpthread 
> addition fixes a build error on my machine.  I will submit a new version 
> of my patch.

Could you give the full build log of host-heimdal on your machine, as
well as the contents of config.log, when the build fails due to
-lpthread being missing?

Thanks,

Thomas

Dear Ryan Coe,

On Tue, 21 Apr 2015 21:50:02 -0700, Ryan Coe wrote:

> (cd 
> /home/ryan/devel/buildroot/buildroot-git/output/build/host-heimdal-1.5.3/ && 
> rm -rf config.cache; 
> PATH="/home/ryan/devel/buildroot/buildroot-git/output/host/bin:/home/ryan/devel/buildroot/buildroot-git/output/host/sbin:/home/ryan/devel/buildroot/buildroot-git/output/host/usr/bin:/home/ryan/devel/buildroot/buildroot-git/output/host/usr/sbin:/home/ryan/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games" 
> AR="/usr/bin/ar" AS="/usr/bin/as" LD="/usr/bin/ld" NM="/usr/bin/nm" 
> CC="/usr/bin/gcc" GCC="/usr/bin/gcc" CXX="/usr/bin/g++" 
> CPP="/usr/bin/cpp" OBJCOPY="/usr/bin/objcopy" RANLIB="/usr/bin/ranlib" 
> CPPFLAGS="-I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include" 
> CFLAGS="-O2 
> -I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include" 
> CXXFLAGS="-O2 
> -I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include" 
> LDFLAGS="-L/home/ryan/devel/buildroot/buildroot-git/output/host/lib 
> -L/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib 
> -Wl,-rpath,/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib" 
> PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 
> PKG_CONFIG="/home/ryan/devel/buildroot/buildroot-git/output/host/usr/bin/pkg-config" 
> PKG_CONFIG_SYSROOT_DIR="/" 
> PKG_CONFIG_LIBDIR="/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib/pkgconfig:/home/ryan/devel/buildroot/buildroot-git/output/host/usr/share/pkgconfig" 
> LD_LIBRARY_PATH="/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib" 
> INTLTOOL_PERL=/usr/bin/perl CFLAGS="-O2 
> -I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include" 
> LDFLAGS="-L/home/ryan/devel/buildroot/buildroot-git/output/host/lib 
> -L/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib 
> -Wl,-rpath,/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib" 
> MAKEINFO=true CONFIG_SITE=/dev/null ./configure 
> --prefix="/home/ryan/devel/buildroot/buildroot-git/output/host/usr" 
> --sysconfdir="/home/ryan/devel/buildroot/buildroot-git/output/host/etc" 
> --localstatedir="/home/ryan/devel/buildroot/buildroot-git/output/host/var" 
> --enable-shared --disable-static --disable-gtk-doc 
> --disable-gtk-doc-html --disable-doc --disable-docs 
> --disable-documentation --disable-debug --with-xmlto=no --with-fop=no 
> --disable-dependency-tracking  --with-x=no --disable-shared 

You don't have my patch applied here. There's still only --with-x=no,
and none of the other --without that my patch is adding.

Please test with the patch applied, thanks!

Thomas