diff mbox

[U-Boot,2/5] dm: usb: Add a terminator to the string destructor list

Message ID 1429449662-9782-3-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass April 19, 2015, 1:20 p.m. UTC
The terminator is missing. Add it for completeness.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/usb/emul/sandbox_hub.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Joe Hershberger April 21, 2015, 3:40 p.m. UTC | #1
Hi Simon,

On Sun, Apr 19, 2015 at 8:20 AM, Simon Glass <sjg@chromium.org> wrote:
> The terminator is missing. Add it for completeness.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
Tested-by: Joe Hershberger <joe.hershberger@ni.com>
Marek Vasut April 21, 2015, 5:08 p.m. UTC | #2
On Tuesday, April 21, 2015 at 05:40:00 PM, Joe Hershberger wrote:
> Hi Simon,
> 
> On Sun, Apr 19, 2015 at 8:20 AM, Simon Glass <sjg@chromium.org> wrote:
> > The terminator is missing. Add it for completeness.
> > 
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> 
> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
> Tested-by: Joe Hershberger <joe.hershberger@ni.com>

Hi Simon,

will you pick these please ?

Best regards,
Marek Vasut
Simon Glass April 21, 2015, 5:11 p.m. UTC | #3
Hi Marek,

Yes, will do. I need to review the pmic stuff too.

Regards,
Simon


On 21 April 2015 at 11:08, Marek Vasut <marex@denx.de> wrote:
> On Tuesday, April 21, 2015 at 05:40:00 PM, Joe Hershberger wrote:
>> Hi Simon,
>>
>> On Sun, Apr 19, 2015 at 8:20 AM, Simon Glass <sjg@chromium.org> wrote:
>> > The terminator is missing. Add it for completeness.
>> >
>> > Signed-off-by: Simon Glass <sjg@chromium.org>
>>
>> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
>> Tested-by: Joe Hershberger <joe.hershberger@ni.com>
>
> Hi Simon,
>
> will you pick these please ?
>
> Best regards,
> Marek Vasut
Simon Glass April 22, 2015, 6:01 p.m. UTC | #4
On 21 April 2015 at 11:11, Simon Glass <sjg@chromium.org> wrote:
> Hi Marek,
>
> Yes, will do. I need to review the pmic stuff too.
>
> Regards,
> Simon
>
>
> On 21 April 2015 at 11:08, Marek Vasut <marex@denx.de> wrote:
>> On Tuesday, April 21, 2015 at 05:40:00 PM, Joe Hershberger wrote:
>>> Hi Simon,
>>>
>>> On Sun, Apr 19, 2015 at 8:20 AM, Simon Glass <sjg@chromium.org> wrote:
>>> > The terminator is missing. Add it for completeness.
>>> >
>>> > Signed-off-by: Simon Glass <sjg@chromium.org>
>>>
>>> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
>>> Tested-by: Joe Hershberger <joe.hershberger@ni.com>
>>
>> Hi Simon,
>>
>> will you pick these please ?
>>
>> Best regards,
>> Marek Vasut

Applied to u-boot-dm.
diff mbox

Patch

diff --git a/drivers/usb/emul/sandbox_hub.c b/drivers/usb/emul/sandbox_hub.c
index 280c708..baf8bdc 100644
--- a/drivers/usb/emul/sandbox_hub.c
+++ b/drivers/usb/emul/sandbox_hub.c
@@ -32,6 +32,7 @@  static struct usb_string hub_strings[] = {
 	{STRING_MANUFACTURER,	"sandbox"},
 	{STRING_PRODUCT,	"hub"},
 	{STRING_SERIAL,		"2345"},
+	{},
 };
 
 static struct usb_device_descriptor hub_device_desc = {