Patchwork target-sparc: fix --enable-debug build for 64 bit host

login
register
mail settings
Submitter Stefan Weil
Date Feb. 25, 2010, 6:05 p.m.
Message ID <1267121141-5099-1-git-send-email-weil@mail.berlios.de>
Download mbox | patch
Permalink /patch/46253/
State New
Headers show

Comments

Stefan Weil - Feb. 25, 2010, 6:05 p.m.
b551ec04ca45d1925417dd2ec7c1b7f115c84f1d fixed
the compilation for 32 bit hosts, but introduced
a new error for 64 bit hosts:

tcg_temp_new_ptr needs a matching tcg_temp_free_ptr.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 target-sparc/translate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jay Foad - Feb. 25, 2010, 6:08 p.m.
On 25 February 2010 18:05, Stefan Weil <weil@mail.berlios.de> wrote:
> b551ec04ca45d1925417dd2ec7c1b7f115c84f1d fixed
> the compilation for 32 bit hosts, but introduced
> a new error for 64 bit hosts:

Sorry. Thanks for fixing it.

Jay.
Blue Swirl - Feb. 25, 2010, 6:41 p.m.
Thanks, applied.

On 2/25/10, Stefan Weil <weil@mail.berlios.de> wrote:
> b551ec04ca45d1925417dd2ec7c1b7f115c84f1d fixed
>  the compilation for 32 bit hosts, but introduced
>  a new error for 64 bit hosts:
>
>  tcg_temp_new_ptr needs a matching tcg_temp_free_ptr.
>
>  Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>  ---
>   target-sparc/translate.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>  diff --git a/target-sparc/translate.c b/target-sparc/translate.c
>  index 18ec65a..9d1ceea 100644
>  --- a/target-sparc/translate.c
>  +++ b/target-sparc/translate.c
>  @@ -1681,7 +1681,7 @@ static inline void gen_load_trap_state_at_tl(TCGv_ptr r_tsptr, TCGv_ptr cpu_env)
>          TCGv_ptr r_tl_tmp = tcg_temp_new_ptr();
>          tcg_gen_ext_i32_ptr(r_tl_tmp, r_tl);
>          tcg_gen_add_ptr(r_tsptr, r_tsptr, r_tl_tmp);
>  -        tcg_temp_free_i32(r_tl_tmp);
>  +        tcg_temp_free_ptr(r_tl_tmp);
>      }
>
>      tcg_temp_free_i32(r_tl);
>
> --
>  1.5.6.5
>
>

Patch

diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 18ec65a..9d1ceea 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/translate.c
@@ -1681,7 +1681,7 @@  static inline void gen_load_trap_state_at_tl(TCGv_ptr r_tsptr, TCGv_ptr cpu_env)
         TCGv_ptr r_tl_tmp = tcg_temp_new_ptr();
         tcg_gen_ext_i32_ptr(r_tl_tmp, r_tl);
         tcg_gen_add_ptr(r_tsptr, r_tsptr, r_tl_tmp);
-        tcg_temp_free_i32(r_tl_tmp);
+        tcg_temp_free_ptr(r_tl_tmp);
     }
 
     tcg_temp_free_i32(r_tl);