Patchwork [4/5] QMP: Drop DEBUG event

login
register
mail settings
Submitter Luiz Capitulino
Date Feb. 25, 2010, 3:07 p.m.
Message ID <1267110422-25873-5-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/46245/
State New
Headers show

Comments

Luiz Capitulino - Feb. 25, 2010, 3:07 p.m.
This event has been introduced in the first round of QMP commits,
turns out that it's based on the usage of the EXCP_DEBUG macro,
which has discussable semantics when exposed through QMP.

As libvirt doesn't use this, let's just drop it.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 QMP/qmp-events.txt |    6 ------
 monitor.c          |    3 ---
 monitor.h          |    1 -
 vl.c               |    1 -
 4 files changed, 0 insertions(+), 11 deletions(-)

Patch

diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index d585a8d..9bf14d0 100644
--- a/QMP/qmp-events.txt
+++ b/QMP/qmp-events.txt
@@ -19,12 +19,6 @@  Data: None.
 Description: Issued when the Virtual Machine is stopped.
 Data: None.
 
-4 DEBUG
--------
-
-Description: Issued when the Virtual Machine enters debug mode.
-Data: None.
-
 4 VNC_CONNECTED
 ---------------
 
diff --git a/monitor.c b/monitor.c
index 19470d1..b2f5842 100644
--- a/monitor.c
+++ b/monitor.c
@@ -399,9 +399,6 @@  void monitor_protocol_event(MonitorEvent event, QObject *data)
     assert(event < QEVENT_MAX);
 
     switch (event) {
-        case QEVENT_DEBUG:
-            event_name = "DEBUG";
-            break;
         case QEVENT_SHUTDOWN:
             event_name = "SHUTDOWN";
             break;
diff --git a/monitor.h b/monitor.h
index fc09505..8cc21f5 100644
--- a/monitor.h
+++ b/monitor.h
@@ -15,7 +15,6 @@  extern Monitor *cur_mon;
 
 /* QMP events */
 typedef enum MonitorEvent {
-    QEVENT_DEBUG,
     QEVENT_SHUTDOWN,
     QEVENT_RESET,
     QEVENT_POWERDOWN,
diff --git a/vl.c b/vl.c
index 2c766c4..3f580f5 100644
--- a/vl.c
+++ b/vl.c
@@ -4054,7 +4054,6 @@  static void main_loop(void)
         } while (vm_can_run());
 
         if (qemu_debug_requested()) {
-            monitor_protocol_event(QEVENT_DEBUG, NULL);
             vm_stop(EXCP_DEBUG);
         }
         if (qemu_shutdown_requested()) {