diff mbox

package/canfestival: switch to using 'hg' to download

Message ID 1429306445-6431-1-git-send-email-yann.morin.1998@free.fr
State Accepted
Headers show

Commit Message

Yann E. MORIN April 17, 2015, 9:34 p.m. UTC
Currently, the canfestival package downloads a archive generated by the
remote Mercurial server.

This has the unfortuante side-effect of downloading an archive name just
after the revision string, without the package name in it. So, users do
have this archive in their BR2_DL_DIR: 7740ac6fdedc.tar.bz2

Switch to doign an hg clone to download canfestival, so we end up with a
properly named archive. Also expand the hash to the full-lenght hash
rather than the shorten one used when asking the remote server to
generate the archive.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Samuel Martin <s.martin49@gmail.com>
---
 package/canfestival/canfestival.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Samuel Martin April 18, 2015, 9:08 a.m. UTC | #1
Yann,

On Fri, Apr 17, 2015 at 11:34 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Currently, the canfestival package downloads a archive generated by the
> remote Mercurial server.
>
> This has the unfortuante side-effect of downloading an archive name just
> after the revision string, without the package name in it. So, users do
> have this archive in their BR2_DL_DIR: 7740ac6fdedc.tar.bz2
>
> Switch to doign an hg clone to download canfestival, so we end up with a
s/doign/doing/

> properly named archive. Also expand the hash to the full-lenght hash
> rather than the shorten one used when asking the remote server to
> generate the archive.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Samuel Martin <s.martin49@gmail.com>

with the typo fixed:
Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Thomas Petazzoni April 18, 2015, 12:44 p.m. UTC | #2
Dear Yann E. MORIN,

On Fri, 17 Apr 2015 23:34:05 +0200, Yann E. MORIN wrote:
> Currently, the canfestival package downloads a archive generated by the
> remote Mercurial server.
> 
> This has the unfortuante side-effect of downloading an archive name just
> after the revision string, without the package name in it. So, users do
> have this archive in their BR2_DL_DIR: 7740ac6fdedc.tar.bz2
> 
> Switch to doign an hg clone to download canfestival, so we end up with a
> properly named archive. Also expand the hash to the full-lenght hash
> rather than the shorten one used when asking the remote server to
> generate the archive.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Samuel Martin <s.martin49@gmail.com>
> ---
>  package/canfestival/canfestival.mk | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/canfestival/canfestival.mk b/package/canfestival/canfestival.mk
index 89e8be5..e929c5e 100644
--- a/package/canfestival/canfestival.mk
+++ b/package/canfestival/canfestival.mk
@@ -4,10 +4,9 @@ 
 #
 ################################################################################
 
-# Revision 791:
-CANFESTIVAL_VERSION = 7740ac6fdedc
-CANFESTIVAL_SOURCE = $(CANFESTIVAL_VERSION).tar.bz2
-CANFESTIVAL_SITE = http://dev.automforge.net/CanFestival-3/archive
+CANFESTIVAL_VERSION = 7740ac6fdedc23e1ed6908d3d7db54833c88572b
+CANFESTIVAL_SITE = http://dev.automforge.net/CanFestival-3
+CANFESTIVAL_SITE_METHOD = hg
 CANFESTIVAL_LICENSE = LGPLv2.1+
 CANFESTIVAL_LICENSE_FILES = COPYING LICENCE
 CANFESTIVAL_INSTALL_STAGING = YES