| Message ID | 1429302375-12275-2-git-send-email-fhunleth@troodon-software.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear Frank Hunleth, On Fri, 17 Apr 2015 16:26:14 -0400, Frank Hunleth wrote: > Users should use BR2_TARGET_UBOOT_PATCHES instead. > > Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> Except that your implementation of BR2_TARGET_UBOOT_PATCHES does not allow the same thing as BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR. BR2_TARGET_UBOOT_PATCHES, as per your current implementation, can only be used for remote patches: they will be downloaded from the given URL if a full URL is given, or from $(UBOOT_SITE) if just a file name is given. See how things are done in linux/linux.mk for an example that allows both remote and local patches. Though I'm not necessarily too happy to see the linux/linux.mk being duplicated... Thanks, Thomas
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in index 32fcb21..6d42d49 100644 --- a/boot/uboot/Config.in +++ b/boot/uboot/Config.in @@ -71,6 +71,7 @@ config BR2_TARGET_UBOOT_VERSION if BR2_TARGET_UBOOT_CUSTOM_GIT || BR2_TARGET_UBOOT_CUSTOM_HG config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR + depends on BR2_DEPRECATED_SINCE_2015_05 string "custom patch dir" help If your board requires custom patches, add the path to the @@ -79,6 +80,8 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR Most users may leave this empty + NOTE: Use BR2_TARGET_UBOOT_PATCHES instead. + config BR2_TARGET_UBOOT_PATCHES string "custom patches" help
Users should use BR2_TARGET_UBOOT_PATCHES instead. Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> --- boot/uboot/Config.in | 3 +++ 1 file changed, 3 insertions(+)