Message ID | 1429290390-5600-1-git-send-email-dvlasenk@redhat.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Denys Vlasenko <dvlasenk@redhat.com> Date: Fri, 17 Apr 2015 19:06:30 +0200 > This inline has ~500 callsites. > > On 04/14/2015 08:37 PM, David Miller wrote: >> That BUG_ON() was added 7 years ago, and I don't remember it ever >> triggering or helping us diagnose something, so just remove it and >> keep the function inlined. > > On x86 allyesconfig build: > > text data bss dec hex filename > 82447071 22255384 20627456 125329911 77861f7 vmlinux4 > 82441375 22255384 20627456 125324215 7784bb7 vmlinux5prime > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/netns/generic.h b/include/net/netns/generic.h index 0931618..70e1585 100644 --- a/include/net/netns/generic.h +++ b/include/net/netns/generic.h @@ -38,11 +38,9 @@ static inline void *net_generic(const struct net *net, int id) rcu_read_lock(); ng = rcu_dereference(net->gen); - BUG_ON(id == 0 || id > ng->len); ptr = ng->ptr[id - 1]; rcu_read_unlock(); - BUG_ON(!ptr); return ptr; } #endif