From patchwork Wed Feb 24 17:55:41 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 46198 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C575AB7CCD for ; Thu, 25 Feb 2010 06:24:52 +1100 (EST) Received: from localhost ([127.0.0.1]:44181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkMqm-0003tu-CH for incoming@patchwork.ozlabs.org; Wed, 24 Feb 2010 14:24:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NkLhG-0003nV-4g for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:54 -0500 Received: from [199.232.76.173] (port=35983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkLhE-0003mi-VH for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:53 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NkLh3-0001P6-Oe for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:52 -0500 Received: from oxygen.pond.sub.org ([213.239.205.148]:37815) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NkLh3-0001OE-0e for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:41 -0500 Received: from blackfin.pond.sub.org (pD9E38C12.dip.t-dialin.net [217.227.140.18]) by oxygen.pond.sub.org (Postfix) with ESMTPA id B36062DD317 for ; Wed, 24 Feb 2010 19:04:30 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 500) id 6C91BD4; Wed, 24 Feb 2010 18:56:02 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 24 Feb 2010 18:55:41 +0100 Message-Id: <1267034160-3517-30-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.6.6 In-Reply-To: <1267034160-3517-1-git-send-email-armbru@redhat.com> References: <1267034160-3517-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [Qemu-devel] [PATCH RFC 29/48] qdev: convert setting device properties to QError X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Markus Armbruster --- hw/qdev-properties.c | 6 ++---- hw/qdev.c | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 8e96805..a3572b0 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -544,13 +544,11 @@ int qdev_prop_parse(DeviceState *dev, const char *name, const char *value) * removed along with it. */ if (!prop || !prop->info->parse) { - fprintf(stderr, "property \"%s.%s\" not found\n", - dev->info->name, name); + qemu_error_new(QERR_PROPERTY_NOT_FOUND, dev->info->name, name); return -1; } if (prop->info->parse(dev, prop, value) != 0) { - fprintf(stderr, "property \"%s.%s\": failed to parse \"%s\"\n", - dev->info->name, name, value); + qemu_error_new(QERR_PROPERTY_VALUE_BAD, dev->info->name, name, value); return -1; } return 0; diff --git a/hw/qdev.c b/hw/qdev.c index 4d5ede7..b170081 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -146,8 +146,6 @@ static int set_property(const char *name, const char *value, void *opaque) return 0; if (qdev_prop_parse(dev, name, value) == -1) { - qemu_error("can't set property \"%s\" to \"%s\" for \"%s\"", - name, value, dev->info->name); return -1; } return 0;