diff mbox

[net-next,S4,01/15] i40e: Collect PFC XOFF RX stats even in single TC case

Message ID 1429229172-143692-2-git-send-email-catherine.sullivan@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show

Commit Message

Catherine Sullivan April 17, 2015, 12:05 a.m. UTC
From: Neerav Parikh <neerav.parikh@intel.com>

When PFC is enabled for any UP in single TC configuration the driver didn't
collect the PFC XOFF RX stats. Though a single TC with PFC enabled is not a
common scenario do not prevent the driver from collecting stats if firmware
indicates that PFC is enabled.

Signed-off-by: Neerav Parikh <neerav.parikh@intel.com>
Change-ID: Ie20bd58b07608b528f3c6d95894c9ae56b00077a
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

James Young May 5, 2015, 5:44 p.m. UTC | #1
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Catherine Sullivan
> Sent: Thursday, April 16, 2015 5:06 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Parikh, Neerav
> Subject: [Intel-wired-lan] [net-next S4 01/15] i40e: Collect PFC XOFF RX stats
> even in single TC case
> 
> From: Neerav Parikh <neerav.parikh@intel.com>
> 
> When PFC is enabled for any UP in single TC configuration the driver didn't
> collect the PFC XOFF RX stats. Though a single TC with PFC enabled is not a
> common scenario do not prevent the driver from collecting stats if firmware
> indicates that PFC is enabled.
> 
> Signed-off-by: Neerav Parikh <neerav.parikh@intel.com>
> Change-ID: Ie20bd58b07608b528f3c6d95894c9ae56b00077a
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Tested-by: Jim Young <james.m.young@intel.com>
	No DCB features tested by my, base driver only, this patch does not affect base driver function.
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 24481cd..c48c8d6 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -772,9 +772,8 @@  static void i40e_update_prio_xoff_rx(struct i40e_pf *pf)
 
 	dcb_cfg = &hw->local_dcbx_config;
 
-	/* See if DCB enabled with PFC TC */
-	if (!(pf->flags & I40E_FLAG_DCB_ENABLED) ||
-	    !(dcb_cfg->pfc.pfcenable)) {
+	/* Collect Link XOFF stats when PFC is disabled */
+	if (!dcb_cfg->pfc.pfcenable) {
 		i40e_update_link_xoff_rx(pf);
 		return;
 	}