| Message ID | 1429217709-21625-1-git-send-email-sridhar.samudrala@intel.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2015-04-16 at 13:55 -0700, Sridhar Samudrala wrote: > Currently 0 is returned on both success or failure. Previously discussed here: <http://thread.gmane.org/gmane.linux.network/349717>. Ben. > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> > --- > ethtool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ethtool.c b/ethtool.c > index 01b13a6..163dff2 100644 > --- a/ethtool.c > +++ b/ethtool.c > @@ -2352,7 +2352,7 @@ static int do_sset(struct cmd_context *ctx) > int argc = ctx->argc; > char **argp = ctx->argp; > int i; > - int err; > + int err = 0; > > for (i = 0; i < ARRAY_SIZE(flags_msglvl); i++) > flag_to_cmdline_info(flags_msglvl[i].name, > @@ -2665,7 +2665,7 @@ static int do_sset(struct cmd_context *ctx) > } > } > > - return 0; > + return err ? 1 : 0; > } > > static int do_gregs(struct cmd_context *ctx)
diff --git a/ethtool.c b/ethtool.c index 01b13a6..163dff2 100644 --- a/ethtool.c +++ b/ethtool.c @@ -2352,7 +2352,7 @@ static int do_sset(struct cmd_context *ctx) int argc = ctx->argc; char **argp = ctx->argp; int i; - int err; + int err = 0; for (i = 0; i < ARRAY_SIZE(flags_msglvl); i++) flag_to_cmdline_info(flags_msglvl[i].name, @@ -2665,7 +2665,7 @@ static int do_sset(struct cmd_context *ctx) } } - return 0; + return err ? 1 : 0; } static int do_gregs(struct cmd_context *ctx)
Currently 0 is returned on both success or failure. Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> --- ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)