| Message ID | 1429121291-28643-1-git-send-email-broonie@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, Apr 15, 2015 at 07:08:11PM +0100, Mark Brown wrote: > This driver uses readw() and writew() which are declared in asm/io.h but > does not explicitly include that header, causing build failures on > architectures where there is not an implicit inclusion such as arm and > arm64: > > ../drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration] > ../drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration] > > Add an explicit inclusion to fix this. > > Signed-off-by: Mark Brown <broonie@kernel.org> Thanks, I just pushed the same fix from Guenter Roeck to -next.
diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c index ce1d69324169..19b2d689a5ef 100644 --- a/drivers/i2c/busses/i2c-jz4780.c +++ b/drivers/i2c/busses/i2c-jz4780.c @@ -23,6 +23,7 @@ #include <linux/i2c.h> #include <linux/init.h> #include <linux/interrupt.h> +#include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/platform_device.h>
This driver uses readw() and writew() which are declared in asm/io.h but does not explicitly include that header, causing build failures on architectures where there is not an implicit inclusion such as arm and arm64: ../drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration] ../drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration] Add an explicit inclusion to fix this. Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/i2c/busses/i2c-jz4780.c | 1 + 1 file changed, 1 insertion(+)