Patchwork [RFC,22/48] qdev: Fix -device and device_add to handle unsuitable bus gracefully

login
register
mail settings
Submitter Markus Armbruster
Date Feb. 24, 2010, 5:55 p.m.
Message ID <1267034160-3517-23-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/46153/
State New
Headers show

Comments

Markus Armbruster - Feb. 24, 2010, 5:55 p.m.
"device_add isa-serial,bus=pci.0" kills QEMU.  Not good.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/qdev.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Patch

diff --git a/hw/qdev.c b/hw/qdev.c
index 38fc4e7..7def97d 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -204,6 +204,11 @@  DeviceState *qdev_device_add(QemuOpts *opts)
     path = qemu_opt_get(opts, "bus");
     if (path != NULL) {
         bus = qbus_find(path);
+        if (bus && bus->info != info->bus_info) {
+            qemu_error("Device '%s' can't go on a %s bus",
+                       driver, bus->info->name);
+            return NULL;
+        }
     } else {
         bus = qbus_find_recursive(main_system_bus, NULL, info->bus_info);
     }