| Message ID | 1429068073-7595-1-git-send-email-linux@roeck-us.net |
|---|---|
| State | Superseded |
| Headers | show |
Guenter, Thanks for catching this! > Fix: > > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw': > drivers/i2c/busses/i2c-jz4780.c:181:2: error: > implicit declaration of function 'readw' > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew': > drivers/i2c/busses/i2c-jz4780.c:187:2: error: > implicit declaration of function 'writew' > > seen with sparc64:allmodconfig and m68k:allmodconfig. > > The driver depends on HAS_IOMEM, and must include linux/io.h. > > Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver > for Ingenic JZ4780") > Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/i2c/busses/Kconfig | 1 + > drivers/i2c/busses/i2c-jz4780.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 2255af23b9c7..c78b6cbd1106 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -586,6 +586,7 @@ config I2C_IOP3XX > config I2C_JZ4780 > tristate "JZ4780 I2C controller interface support" > depends on MACH_JZ4780 || COMPILE_TEST > + depends on HAS_IOMEM You sure? We have menu "I2C Hardware Bus support" depends on HAS_IOMEM in drivers/i2c/busses/Kconfig. For me, menuconfig shows that the driver is already depending on HAS_IOMEM. > help > If you say yes to this option, support will be included for the > Ingenic JZ4780 I2C controller. > diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c > index ce1d69324169..f2761ab2ef32 100644 > --- a/drivers/i2c/busses/i2c-jz4780.c > +++ b/drivers/i2c/busses/i2c-jz4780.c > @@ -21,6 +21,7 @@ > #include <linux/delay.h> > #include <linux/errno.h> > #include <linux/i2c.h> > +#include <linux/io.h> > #include <linux/init.h> > #include <linux/interrupt.h> > #include <linux/kernel.h> The sorting needs to be fixed.
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 2255af23b9c7..c78b6cbd1106 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -586,6 +586,7 @@ config I2C_IOP3XX config I2C_JZ4780 tristate "JZ4780 I2C controller interface support" depends on MACH_JZ4780 || COMPILE_TEST + depends on HAS_IOMEM help If you say yes to this option, support will be included for the Ingenic JZ4780 I2C controller. diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c index ce1d69324169..f2761ab2ef32 100644 --- a/drivers/i2c/busses/i2c-jz4780.c +++ b/drivers/i2c/busses/i2c-jz4780.c @@ -21,6 +21,7 @@ #include <linux/delay.h> #include <linux/errno.h> #include <linux/i2c.h> +#include <linux/io.h> #include <linux/init.h> #include <linux/interrupt.h> #include <linux/kernel.h>
Fix: drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw': drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew': drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' seen with sparc64:allmodconfig and m68k:allmodconfig. The driver depends on HAS_IOMEM, and must include linux/io.h. Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver for Ingenic JZ4780") Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-jz4780.c | 1 + 2 files changed, 2 insertions(+)