From patchwork Tue Apr 14 22:39:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland McGrath X-Patchwork-Id: 461288 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D1D8F14027F for ; Wed, 15 Apr 2015 08:39:25 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=sourceware.org header.i=@sourceware.org header.b=soOMreuo; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; q= dns; s=default; b=d+NA59oD5ZSObd0l61v+pjURbw6rPstH4uOj+3iSVQ/5nA A3WNV+jLeTduiJ4ie0+Djus9UGdWLa6C4p0a6u1DJ0NgGL0usKvQr0DWFJUqQBDj nORgYz746b+3EPxmO/JWO4Oa+J323W/2PvaA8HUShgBUlfcN51m8Dv/dTtDs4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; s= default; bh=/0eSvcI5WnUkhft4RniDKsWmt+4=; b=soOMreuo0a59dZrx6F9i L52BgtpLsfSncxp8Js1DxAP0xALXDVnVhUDkRO3wnWWtckTtLagHfPffIPLH2kfm r1Ni/KYl3GyIfZV3hbi0COX7VJWQeLaBDDohlazNZIUuiEW11vA4p5hVgaooF0P8 LN23uugRBg2eugH/1gw2b/0= Received: (qmail 128578 invoked by alias); 14 Apr 2015 22:39:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 128555 invoked by uid 89); 14 Apr 2015 22:39:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 From: Roland McGrath To: "GNU C. Library" Subject: [PATCH roland/arm] ARM: Define PI_STATIC_AND_HIDDEN. Message-Id: <20150414223916.9B4782C3BDC@topped-with-meat.com> Date: Tue, 14 Apr 2015 15:39:16 -0700 (PDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=SvUDtp+0 c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=dMYVFXXhpogpAS0HPFwA:9 a=CjuIK1q_8ugA:10 I suspect this is now safe. (It caused no apparent mischief in my arm-linux-gnueabihf build using GCC 4.8.2.) But I don't actually know what GCC version is implied by "added by the GCC TLS patches". I'm guessing that 4.6 (our minimum) is new enough that this is always true now. If that's true, it would be nice to know the appropriate GCC version number for sure and mention that in the comment. If it is really still the case that some supported compiler versions or configurations do not reliably do pure PI access to static/hidden, then I'd like to have enough information about that to write a proper configure test. Thanks, Roland 2015-04-14 Roland McGrath * sysdeps/arm/configure.ac (PI_STATIC_AND_HIDDEN): Define it. * sysdeps/arm/configure: Regenerated. --- a/sysdeps/arm/configure +++ b/sysdeps/arm/configure @@ -1,7 +1,8 @@ # This file is generated from configure.ac by Autoconf. DO NOT EDIT! # Local configure fragment for sysdeps/arm. -#AC_DEFINE(PI_STATIC_AND_HIDDEN) +$as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h + # We check to see if the compiler and flags are # selecting the hard-float ABI and if they are then --- a/sysdeps/arm/configure.ac +++ b/sysdeps/arm/configure.ac @@ -3,9 +3,7 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. dnl It is always possible to access static and hidden symbols in an dnl position independent way. -dnl NOTE: This feature was added by the GCC TLS patches. We should test for -dnl it. Until we do, don't define it. -#AC_DEFINE(PI_STATIC_AND_HIDDEN) +AC_DEFINE(PI_STATIC_AND_HIDDEN) # We check to see if the compiler and flags are # selecting the hard-float ABI and if they are then