| Message ID | 1428933661-8193-5-git-send-email-pavlix@pavlix.net |
|---|---|
| State | Rejected, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Mon, 13 Apr 2015 16:00:59 +0200 Pavel Šimerda <pavlix@pavlix.net> wrote: > From: Pavel Šimerda <psimerda@redhat.com> > > Signed-off-by: Pavel Šimerda <psimerda@redhat.com> > --- > ip/iproute.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I understand your concern, and it probably was a poor design choice initially. Since this will change the output for the default case, it will upset some peoples expectations and potentially break scripts that screen scrape the output of ip commands. Therefore I can't accept it at this time. Sorry for the delay, but I thought someone else would add more comments. Perhaps if you explained in more detail the motivation of why this is an important problem I would reconsider change the behavior. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 4 May 2015 08:37:51 -0700 > On Mon, 13 Apr 2015 16:00:59 +0200 > Pavel Šimerda <pavlix@pavlix.net> wrote: > >> From: Pavel Šimerda <psimerda@redhat.com> >> >> Signed-off-by: Pavel Šimerda <psimerda@redhat.com> >> --- >> ip/iproute.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > I understand your concern, and it probably was a poor design choice initially. > > Since this will change the output for the default case, it will upset some > peoples expectations and potentially break scripts that screen scrape the output > of ip commands. Therefore I can't accept it at this time. > > Sorry for the delay, but I thought someone else would add more comments. > Perhaps if you explained in more detail the motivation of why this is an > important problem I would reconsider change the behavior. We definitely need to report routes created by caching/cloning separately from the main FIB entries. And I agree that even if we wanted to change behavior, the horse has already left the barn on this one and therefore there is no way we can change this now. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/04/2015 08:37 PM, David Miller wrote: > From: Stephen Hemminger <stephen@networkplumber.org> > Date: Mon, 4 May 2015 08:37:51 -0700 > >> On Mon, 13 Apr 2015 16:00:59 +0200 >> Pavel Šimerda <pavlix@pavlix.net> wrote: >> >>> From: Pavel Šimerda <psimerda@redhat.com> >>> >>> Signed-off-by: Pavel Šimerda <psimerda@redhat.com> >>> --- >>> ip/iproute.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> I understand your concern, and it probably was a poor design choice initially. >> >> Since this will change the output for the default case, it will upset some >> peoples expectations and potentially break scripts that screen scrape the output >> of ip commands. Therefore I can't accept it at this time. >> >> Sorry for the delay, but I thought someone else would add more comments. >> Perhaps if you explained in more detail the motivation of why this is an >> important problem I would reconsider change the behavior. Hi, I have no specific concern right now. > We definitely need to report routes created by caching/cloning separately > from the main FIB entries. > > And I agree that even if we wanted to change behavior, the horse has > already left the barn on this one and therefore there is no way we can > change this now. For now I treat the patch as rejected by upstream and as I'm not aware of a specific concern for Fedora, I'm also dropping the patch from the development branch[1]. Thank you for accepting other patches. My plan is to submit new patches for requests coming from Fedora and RHEL distributions and also resubmit the manpage patches with new changes and split by command/subcommand. Cheers, Pavel [1]: http://pkgs.fedoraproject.org/cgit/iproute.git/commit/?id=f0557f39740b5c18f07b2caf634eb073ba19484f -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ip/iproute.c b/ip/iproute.c index 024d401..46c24bb 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -144,7 +144,7 @@ static int filter_nlmsg(struct nlmsghdr *n, struct rtattr **tb, int host_len) if (r->rtm_family == AF_INET6 && table != RT_TABLE_MAIN) ip6_multiple_tables = 1; - if (filter.cloned == !(r->rtm_flags&RTM_F_CLONED)) + if (filter.cloned && !(r->rtm_flags&RTM_F_CLONED)) return 0; if (r->rtm_family == AF_INET6 && !ip6_multiple_tables) {