| Message ID | 1428856685-4403-19-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
On 12/04/15 18:38, Thomas Petazzoni wrote: > Just like <pkg>_PATCH, <pkg>_SOURCE or <pkg>_SITE, the > <pkg>_EXTRA_DOWNLOADS variable of a host package should be > automatically inferred from the <pkg>_EXTRA_DOWNLOADS value of the > corresponding target package, unless an explicit value is being > defined for the host package. This commit implements this for > <pkg>_EXTRA_DOWNLOADS. I'm not so sure about this one. _EXTRA_DOWNLOADS is currently used for the blackfin toolchains and for perl. Toolchains are target packages so no issue there, but for perl, we really only need perl-cross for the target perl. At the moment, host-perl is only built as a dependency of perl so it doesn't hurt to download perl-cross for host-perl, but it is unnecessary. Is there a hidden reason why you want this (i.e. is it required for some later patch)? Regards, Arnout > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > package/pkg-generic.mk | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk > index 13a3843..d2ed605 100644 > --- a/package/pkg-generic.mk > +++ b/package/pkg-generic.mk > @@ -353,6 +353,12 @@ ifndef $(2)_PATCH > endif > endif > > +ifndef $(2)_EXTRA_DOWNLOADS > + ifdef $(3)_EXTRA_DOWNLOADS > + $(2)_PATCH = $$($(3)_EXTRA_DOWNLOADS) > + endif > +endif > + > ifndef $(2)_SITE > ifdef $(3)_SITE > $(2)_SITE = $$($(3)_SITE) >
Dear Arnout Vandecappelle, On Tue, 14 Apr 2015 23:50:59 +0200, Arnout Vandecappelle wrote: > On 12/04/15 18:38, Thomas Petazzoni wrote: > > Just like <pkg>_PATCH, <pkg>_SOURCE or <pkg>_SITE, the > > <pkg>_EXTRA_DOWNLOADS variable of a host package should be > > automatically inferred from the <pkg>_EXTRA_DOWNLOADS value of the > > corresponding target package, unless an explicit value is being > > defined for the host package. This commit implements this for > > <pkg>_EXTRA_DOWNLOADS. > > I'm not so sure about this one. _EXTRA_DOWNLOADS is currently used for the > blackfin toolchains and for perl. Toolchains are target packages so no issue > there, but for perl, we really only need perl-cross for the target perl. At the > moment, host-perl is only built as a dependency of perl so it doesn't hurt to > download perl-cross for host-perl, but it is unnecessary. > > Is there a hidden reason why you want this (i.e. is it required for some later > patch)? Not that I remember of. The only reason was pure consistency: since source, site, version and patch are all inherited from the target variant to the host variant, is seemed to make sense as well for extra downloads. I can get rid of this aspect if you think it's not really appropriate, since I indeed don't really have a use case for it, except a pure consistency feeling. Thanks for the review! Thomas
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 13a3843..d2ed605 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -353,6 +353,12 @@ ifndef $(2)_PATCH endif endif +ifndef $(2)_EXTRA_DOWNLOADS + ifdef $(3)_EXTRA_DOWNLOADS + $(2)_PATCH = $$($(3)_EXTRA_DOWNLOADS) + endif +endif + ifndef $(2)_SITE ifdef $(3)_SITE $(2)_SITE = $$($(3)_SITE)
Just like <pkg>_PATCH, <pkg>_SOURCE or <pkg>_SITE, the <pkg>_EXTRA_DOWNLOADS variable of a host package should be automatically inferred from the <pkg>_EXTRA_DOWNLOADS value of the corresponding target package, unless an explicit value is being defined for the host package. This commit implements this for <pkg>_EXTRA_DOWNLOADS. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/pkg-generic.mk | 6 ++++++ 1 file changed, 6 insertions(+)