| Message ID | 1428856685-4403-14-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
Thomas, All, On 2015-04-12 18:37 +0200, Thomas Petazzoni spake thusly: > This commit switches the implementation of the global source-check > target to use a package infrastructure based mechanism, using the > $(1)-all-source-check target added in the previous commit. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr> [tested against a randpackageconfig] Regards, Yann E. MORIN. > --- > Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 6937dd3..7d94ee8 100644 > --- a/Makefile > +++ b/Makefile > @@ -617,8 +617,7 @@ external-deps: > @$(MAKE1) -Bs $(EXTRAMAKEARGS) _external-deps | sort -u > > # check if download URLs are outdated > -source-check: > - $(MAKE1) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source > +source-check: $(foreach p,$(PACKAGES),$(p)-all-source-check) > > legal-info-clean: > @rm -fr $(LEGAL_INFO_DIR) > -- > 2.1.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On 12/04/15 18:37, Thomas Petazzoni wrote: > This commit switches the implementation of the global source-check > target to use a package infrastructure based mechanism, using the > $(1)-all-source-check target added in the previous commit. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> There is something still missing to complete the conversion: some packages (at91bootstrap, at91bootstrap3, barebox, uboot, xloader, linux, sunxi-boards) check that the configuration files specified in .config really exist, _unless_ make source is called (presumably this exception is to support the 'make allpackageyesconfig; make source' way of refreshing the buildroot mirror). Previously (actually, before you removed source-check from noconfig_targets), this would also apply to source-check, but now it doesn't anymore. So I'd update all those filter expressions with source-check as well. But that doesn't affect this patch, so Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > --- > Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 6937dd3..7d94ee8 100644 > --- a/Makefile > +++ b/Makefile > @@ -617,8 +617,7 @@ external-deps: > @$(MAKE1) -Bs $(EXTRAMAKEARGS) _external-deps | sort -u > > # check if download URLs are outdated > -source-check: > - $(MAKE1) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source > +source-check: $(foreach p,$(PACKAGES),$(p)-all-source-check) > > legal-info-clean: > @rm -fr $(LEGAL_INFO_DIR) >
diff --git a/Makefile b/Makefile index 6937dd3..7d94ee8 100644 --- a/Makefile +++ b/Makefile @@ -617,8 +617,7 @@ external-deps: @$(MAKE1) -Bs $(EXTRAMAKEARGS) _external-deps | sort -u # check if download URLs are outdated -source-check: - $(MAKE1) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source +source-check: $(foreach p,$(PACKAGES),$(p)-all-source-check) legal-info-clean: @rm -fr $(LEGAL_INFO_DIR)
This commit switches the implementation of the global source-check target to use a package infrastructure based mechanism, using the $(1)-all-source-check target added in the previous commit. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)