PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing
diff mbox

Message ID 1428790513-22902-1-git-send-email-rep.dot.nop@gmail.com
State New
Headers show

Commit Message

Bernhard Reutner-Fischer April 11, 2015, 10:15 p.m. UTC
gcc/config/openbsd.h:143:18: error: ‘OBSD_LIB_SPEC’ was not declared in
this scope
 #define LIB_SPEC OBSD_LIB_SPEC
                  ^
gcc/gcc.c:879:31: note:
in expansion of macro ‘LIB_SPEC’
 static const char *lib_spec = LIB_SPEC;
                               ^
make[2]: *** [gcc.o] Error 1

Is the patch below ok for trunk?

i.e. openbsd-oldgas.h is only used on
i?86-*-openbsd2.*|i?86-*openbsd3.[0123] so is right on spot it seems.

Alternatively remove openbsd <= 3.3 support altogether since openbsd-3.3 was
released May 1, 2003.
This probably needs a deprecation announcement from Release Managers or
something.

gcc/ChangeLog:

2015-04-10  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>

	PR target/47098
	* config/openbsd-oldgas.h (OBSD_LIB_SPEC): Add.
---
 gcc/config/openbsd-oldgas.h |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Jeff Law April 13, 2015, 1:08 p.m. UTC | #1
On 04/11/2015 04:15 PM, Bernhard Reutner-Fischer wrote:
> gcc/config/openbsd.h:143:18: error: ‘OBSD_LIB_SPEC’ was not declared in
> this scope
>   #define LIB_SPEC OBSD_LIB_SPEC
>                    ^
> gcc/gcc.c:879:31: note:
> in expansion of macro ‘LIB_SPEC’
>   static const char *lib_spec = LIB_SPEC;
>                                 ^
> make[2]: *** [gcc.o] Error 1
>
> Is the patch below ok for trunk?
>
> i.e. openbsd-oldgas.h is only used on
> i?86-*-openbsd2.*|i?86-*openbsd3.[0123] so is right on spot it seems.
>
> Alternatively remove openbsd <= 3.3 support altogether since openbsd-3.3 was
> released May 1, 2003.
> This probably needs a deprecation announcement from Release Managers or
> something.
>
> gcc/ChangeLog:
>
> 2015-04-10  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>
>
> 	PR target/47098
> 	* config/openbsd-oldgas.h (OBSD_LIB_SPEC): Add.
OK.

If you want to deprecate the ancient openbsd support, that can be a 
follow-up.

Jeff
Bernhard Reutner-Fischer April 22, 2015, 8:42 a.m. UTC | #2
On 13 April 2015 at 15:08, Jeff Law <law@redhat.com> wrote:
> On 04/11/2015 04:15 PM, Bernhard Reutner-Fischer wrote:
>>
>> gcc/config/openbsd.h:143:18: error: ‘OBSD_LIB_SPEC’ was not declared in
>> this scope
>>   #define LIB_SPEC OBSD_LIB_SPEC
>>                    ^
>> gcc/gcc.c:879:31: note:
>> in expansion of macro ‘LIB_SPEC’
>>   static const char *lib_spec = LIB_SPEC;
>>                                 ^
>> make[2]: *** [gcc.o] Error 1
>>
>> Is the patch below ok for trunk?
>>
>> i.e. openbsd-oldgas.h is only used on
>> i?86-*-openbsd2.*|i?86-*openbsd3.[0123] so is right on spot it seems.
>>
>> Alternatively remove openbsd <= 3.3 support altogether since openbsd-3.3
>> was
>> released May 1, 2003.
>> This probably needs a deprecation announcement from Release Managers or
>> something.
>>
>> gcc/ChangeLog:
>>
>> 2015-04-10  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>
>>
>>         PR target/47098
>>         * config/openbsd-oldgas.h (OBSD_LIB_SPEC): Add.
>
> OK.

Thanks, committed to trunk as r222315.
>
> If you want to deprecate the ancient openbsd support, that can be a
> follow-up.

I wouldn't dare :)

thanks,

Patch
diff mbox

diff --git a/gcc/config/openbsd-oldgas.h b/gcc/config/openbsd-oldgas.h
index 04a4d37..5cef1eb 100644
--- a/gcc/config/openbsd-oldgas.h
+++ b/gcc/config/openbsd-oldgas.h
@@ -20,3 +20,7 @@  along with GCC; see the file COPYING3.  If not see
 
 
 #define OBSD_OLD_GAS
+
+/* OpenBSD3.0 had no libpthread, pthreads lived in -lc_r */
+#define OBSD_LIB_SPEC "%{!shared:-lc%{pthread:_r}}"
+