[1/2] pinctrl: mvebu: Fix mapping of pin 63 (gpo -> gpio)
diff mbox

Message ID 1428784160-19431-2-git-send-email-andrew@ncrmnt.org
State New
Headers show

Commit Message

Andrew Andrianov April 11, 2015, 8:29 p.m. UTC
Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
---
 drivers/pinctrl/mvebu/pinctrl-armada-370.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij April 27, 2015, 1:24 p.m. UTC | #1
On Sat, Apr 11, 2015 at 10:29 PM, Andrew Andrianov <andrew@ncrmnt.org> wrote:

> Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>

Patch applied for fixes.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thomas Petazzoni May 29, 2015, 9:10 a.m. UTC | #2
Dear Andrew Andrianov,

On Sat, 11 Apr 2015 23:29:19 +0300, Andrew Andrianov wrote:
> Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
> ---
>  drivers/pinctrl/mvebu/pinctrl-armada-370.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-370.c b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> index c4f51d0..78c332d 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
> @@ -364,7 +364,7 @@ static struct mvebu_mpp_mode mv88f6710_mpp_modes[] = {
>  	   MPP_FUNCTION(0x5, "audio", "mclk"),
>  	   MPP_FUNCTION(0x6, "uart0", "cts")),
>  	MPP_MODE(63,
> -	   MPP_FUNCTION(0x0, "gpo", NULL),
> +	   MPP_FUNCTION(0x0, "gpio", NULL),
>  	   MPP_FUNCTION(0x1, "spi0", "sck"),
>  	   MPP_FUNCTION(0x2, "tclk", NULL)),
>  	MPP_MODE(64,

I know the patch has already been applied, but this is weird: I just
checked the datasheet again, and it really says this pin is a "gpo".
I'll try to get some more information.

Best regards,

Thomas
Andrew Andrianov May 29, 2015, 9:55 a.m. UTC | #3
Thomas Petazzoni писал 29.05.2015 12:10:
> Dear Andrew Andrianov,
> 
> On Sat, 11 Apr 2015 23:29:19 +0300, Andrew Andrianov wrote:
>> Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
>> ---
>>  drivers/pinctrl/mvebu/pinctrl-armada-370.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-370.c 
>> b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
>> index c4f51d0..78c332d 100644
>> --- a/drivers/pinctrl/mvebu/pinctrl-armada-370.c
>> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
>> @@ -364,7 +364,7 @@ static struct mvebu_mpp_mode mv88f6710_mpp_modes[] 
>> = {
>>  	   MPP_FUNCTION(0x5, "audio", "mclk"),
>>  	   MPP_FUNCTION(0x6, "uart0", "cts")),
>>  	MPP_MODE(63,
>> -	   MPP_FUNCTION(0x0, "gpo", NULL),
>> +	   MPP_FUNCTION(0x0, "gpio", NULL),
>>  	   MPP_FUNCTION(0x1, "spi0", "sck"),
>>  	   MPP_FUNCTION(0x2, "tclk", NULL)),
>>  	MPP_MODE(64,
> 
> I know the patch has already been applied, but this is weird: I just
> checked the datasheet again, and it really says this pin is a "gpo".
> I'll try to get some more information.
> 
> Best regards,
> 
> Thomas

Yep, exactly. I've seen that in the public docs. It must be a typo,
unless there's something we don't know.

On DNS-327L this pin is wired as a button. Without th patch only
gpio-buttons driver fails probing, but you can still configure the pin
as input via sysfs gpio interface and even read sensible values from it.
If you have a board where this pin is broken out - it's easy to test.
Thomas Petazzoni May 29, 2015, 10:06 a.m. UTC | #4
Andrew,

On Fri, 29 May 2015 12:55:44 +0300, Andrew wrote:

> Yep, exactly. I've seen that in the public docs. It must be a typo,
> unless there's something we don't know.
> 
> On DNS-327L this pin is wired as a button. Without th patch only
> gpio-buttons driver fails probing, but you can still configure the pin
> as input via sysfs gpio interface and even read sensible values from it.
> If you have a board where this pin is broken out - it's easy to test.

Ok, I've made a request for Marvell to check this aspect. If there's a
mistake, they should hopefully fix the datasheet at some point.

Thanks,

Thomas

Patch
diff mbox

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-370.c b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
index c4f51d0..78c332d 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-370.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-370.c
@@ -364,7 +364,7 @@  static struct mvebu_mpp_mode mv88f6710_mpp_modes[] = {
 	   MPP_FUNCTION(0x5, "audio", "mclk"),
 	   MPP_FUNCTION(0x6, "uart0", "cts")),
 	MPP_MODE(63,
-	   MPP_FUNCTION(0x0, "gpo", NULL),
+	   MPP_FUNCTION(0x0, "gpio", NULL),
 	   MPP_FUNCTION(0x1, "spi0", "sck"),
 	   MPP_FUNCTION(0x2, "tclk", NULL)),
 	MPP_MODE(64,