[COMMITTED] Omit libc-modules.h for all .v.i files.
diff mbox

Message ID 20150409214445.E08512C3B9E@topped-with-meat.com
State New
Headers show

Commit Message

Roland McGrath April 9, 2015, 9:44 p.m. UTC
The shlib-versions and Versions files are not really special.
All files we run through cpp with the .v.i treatment are things
where IS_IN makes no sense, and might well be things that need
to be generated before libc-modules.h is available.


Thanks,
Roland


	* Makeconfig (module-cppflags): Exclude all .v.i files.
	(skip-module-cppflags): Variable removed.

Patch
diff mbox

--- a/Makeconfig
+++ b/Makeconfig
@@ -848,12 +848,6 @@  built-modules = iconvprogs iconvdata ldconfig lddlibc4 libmemusage \
 		libSegFault libpcprofile librpcsvc locale-programs \
 		memusagestat nonlib nscd extramodules libnldbl
 
-# We don't include libc-modules.h when these targets are being built.  These
-# targets don't (and will likely never need to) use the IS_IN facility.  In
-# fact, shlib-versions should not use it because that will create a circular
-# dependency as libc-modules.h is generated from shlib-versions.
-skip-module-cppflags = shlib-versions.v.i Versions.v.i
-
 in-module = $(subst -,_,$(firstword $(libof-$(basename $(@F))) \
 				    $(libof-$(<F)) \
 				    $(libof-$(@F)) \
@@ -862,10 +856,12 @@  in-module = $(subst -,_,$(firstword $(libof-$(basename $(@F))) \
 module-cppflags-real = -include $(common-objpfx)libc-modules.h \
 		       -DMODULE_NAME=$(in-module)
 
-# We don't need libc-modules.h and the MODULE_NAME definition for
-# shlib-version.v.i.
-module-cppflags = $(if $(filter $(@F),$(skip-module-cppflags)), \
-		       ,$(module-cppflags-real))
+# We don't need libc-modules.h and the MODULE_NAME definition for .v.i
+# files.  These targets don't (and will likely never need to) use the IS_IN
+# facility.  In fact, shlib-versions should not use it because that will
+# create a circular dependency as libc-modules.h is generated from
+# shlib-versions.
+module-cppflags = $(if $(filter %.v.i,$(@F)),,$(module-cppflags-real))
 
 # These are the variables that the implicit compilation rules use.
 # Note that we can't use -std=* in CPPFLAGS, because it overrides