| Message ID | 20150409194923.19293.96454.stgit@bhelgaas-glaptop2.roam.corp.google.com |
|---|---|
| State | Accepted |
| Headers | show |
SGkgQmpvcm4sDQoNClRoYW5rcyBmb3IgeW91ciBpbXByb3ZlbWVudC4NCkkgbm90aWNlIG15IG5l dyBwYXRjaGVzIHRvIGFkZCBzdXBwb3J0IGFybTMyIGFuZCBhcm02NCBmb3IgZGVzaWdud2FyZSBh bmQgbGF5ZXJzY2FwZSBhbHNvIGhhdmUgdGhlIHNpbWlsYXIgaXNzdWVzLCBJIHdpbGwgZml4IGFu ZCBzdWJtaXQgIHRoZW0gdjIgLg0KQ291bGQgeW91IHRlbGwgbWUgd2hldGhlciBpdCBpcyBhY2Nl cHRhYmxlIHRoYXQgSSBhZGQgYSBuZXcgZmlsZSBwY2llLWRlc2lnbndhcmUtYmFzZS5jICB0byBy ZS1pbXBsZW1lbnQgZGVzaWdud2FyZSBQQ0llIGRyaXZlciBmb3IgY29tcGF0aWJsZSB3aXRoIGFy bTMyIGFuZCBhcm02NC4gIFRoZSBiZW5lZml0ICBpcyB0aGF0ICB0aGUgbmV3IGltcGxlbWVudGF0 aW9uIGlzIHNpbXBsZSBjbGVhciBhbmQgcGxhdGZvcm0taW5kZXBlbmRlbnQuIEluIGFkZGl0aW9u LCBNU0kgZHJpdmVyIHdpbGwgYmUgc3BsaXQgdG8gYSBzZXBhcmF0ZSBmaWxlLiBCdXQgd2UgbWF5 IG5lZWQgdG8gcHVzaCBvdGhlciBwbGF0Zm9ybSBQQ0llIG1haW50YWluZXIgdG8gcG9ydCB0aGUg ZHJpdmVyIGJhc2VkIG9uIHBjaWUtZGVzaWdud2FyZS1iYXNlLmMgLg0KDQpUaGFua3MsDQpNaW5n aHVhbg0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQmpvcm4gSGVs Z2FhcyBbbWFpbHRvOmJoZWxnYWFzQGdvb2dsZS5jb21dDQo+IFNlbnQ6IEZyaWRheSwgQXByaWwg MTAsIDIwMTUgMzo0OSBBTQ0KPiBUbzogTGlhbiBNaW5naHVhbi1CMzE5Mzk7IEh1IE1pbmdrYWkt QjIxMjg0OyBaYW5nIFJveS1SNjE5MTENCj4gQ2M6IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmcN Cj4gU3ViamVjdDogW1BBVENIXSBQQ0k6IGxheWVyc2NhcGU6IFNpbXBsaWZ5IHBsYXRmb3JtX2dl dF9yZXNvdXJjZV9ieW5hbWUoKQ0KPiBmYWlsdXJlIGNoZWNraW5nDQo+IA0KPiBkZXZtX2lvcmVt YXBfcmVzb3VyY2UoKSB2YWxpZGF0ZXMgdGhlIHJlc291cmNlIGl0IHJlY2VpdmVzLCBzbyBpZiB3 ZSBjaGVjaw0KPiBmb3IgZGV2bV9pb3JlbWFwX3Jlc291cmNlKCkgZmFpbHVyZSwgd2UgbmVlZCBu b3QgY2hlY2sgZm9yIGZhaWx1cmUgb2YgdGhlDQo+IHByZWNlZGluZyBwbGF0Zm9ybV9nZXRfcmVz b3VyY2UoKS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdv b2dsZS5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9wY2kvaG9zdC9wY2ktbGF5ZXJzY2FwZS5jIHwg ICAgOSArKystLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDYgZGVs ZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvaG9zdC9wY2ktbGF5ZXJz Y2FwZS5jIGIvZHJpdmVycy9wY2kvaG9zdC9wY2ktDQo+IGxheWVyc2NhcGUuYw0KPiBpbmRleCA2 OGM5ZTVlOWIwYTguLjRhNmU2MmY2NzU3OSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9wY2kvaG9z dC9wY2ktbGF5ZXJzY2FwZS5jDQo+ICsrKyBiL2RyaXZlcnMvcGNpL2hvc3QvcGNpLWxheWVyc2Nh cGUuYw0KPiBAQCAtMTI3LDE0ICsxMjcsMTEgQEAgc3RhdGljIGludCBfX2luaXQgbHNfcGNpZV9w cm9iZShzdHJ1Y3QNCj4gcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiAgCXBjaWUtPmRldiA9ICZw ZGV2LT5kZXY7DQo+IA0KPiAgCWRiaV9iYXNlID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlX2J5bmFt ZShwZGV2LA0KPiBJT1JFU09VUkNFX01FTSwgInJlZ3MiKTsNCj4gLQlpZiAoIWRiaV9iYXNlKSB7 DQo+IC0JCWRldl9lcnIoJnBkZXYtPmRldiwgIm1pc3NpbmcgKnJlZ3MqIHNwYWNlXG4iKTsNCj4g LQkJcmV0dXJuIC1FTk9ERVY7DQo+IC0JfQ0KPiAtDQo+ICAJcGNpZS0+ZGJpID0gZGV2bV9pb3Jl bWFwX3Jlc291cmNlKCZwZGV2LT5kZXYsIGRiaV9iYXNlKTsNCj4gLQlpZiAoSVNfRVJSKHBjaWUt PmRiaSkpDQo+ICsJaWYgKElTX0VSUihwY2llLT5kYmkpKSB7DQo+ICsJCWRldl9lcnIoJnBkZXYt PmRldiwgIm1pc3NpbmcgKnJlZ3MqIHNwYWNlXG4iKTsNCj4gIAkJcmV0dXJuIFBUUl9FUlIocGNp ZS0+ZGJpKTsNCj4gKwl9DQo+IA0KPiAgCXBjaWUtPnNjZmcgPSBzeXNjb25fcmVnbWFwX2xvb2t1 cF9ieV9waGFuZGxlKHBkZXYtDQo+ID5kZXYub2Zfbm9kZSwNCj4gIAkJCQkJCSAgICAgImZzbCxw Y2llLXNjZmciKTsNCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Freitag, den 10.04.2015, 02:08 +0000 schrieb Minghuan.Lian@freescale.com: > Hi Bjorn, > > Thanks for your improvement. > I notice my new patches to add support arm32 and arm64 for designware > and layerscape also have the similar issues, I will fix and submit > them v2 . > Could you tell me whether it is acceptable that I add a new file > pcie-designware-base.c to re-implement designware PCIe driver for > compatible with arm32 and arm64. The benefit is that the new > implementation is simple clear and platform-independent. In addition, > MSI driver will be split to a separate file. But we may need to push > other platform PCIe maintainer to port the driver based on > pcie-designware-base.c . > In that case you probably should have put the other maintainers of designware based PCI drivers on CC for your patches. You will not gain momentum for such a radical change if you fail to address the right people. Regards, Lucas
On Fri, Apr 10, 2015 at 4:40 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Am Freitag, den 10.04.2015, 02:08 +0000 schrieb > Minghuan.Lian@freescale.com: >> Hi Bjorn, >> >> Thanks for your improvement. >> I notice my new patches to add support arm32 and arm64 for designware >> and layerscape also have the similar issues, I will fix and submit >> them v2 . >> Could you tell me whether it is acceptable that I add a new file >> pcie-designware-base.c to re-implement designware PCIe driver for >> compatible with arm32 and arm64. The benefit is that the new >> implementation is simple clear and platform-independent. In addition, >> MSI driver will be split to a separate file. But we may need to push >> other platform PCIe maintainer to port the driver based on >> pcie-designware-base.c . >> > In that case you probably should have put the other maintainers of > designware based PCI drivers on CC for your patches. You will not gain > momentum for such a radical change if you fail to address the right > people. I haven't reviewed your patches in detail, but you might need to go even farther and do the conversion yourself. That's what somebody introducing new infrastructure usually does. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 68c9e5e9b0a8..4a6e62f67579 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -127,14 +127,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev) pcie->dev = &pdev->dev; dbi_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs"); - if (!dbi_base) { - dev_err(&pdev->dev, "missing *regs* space\n"); - return -ENODEV; - } - pcie->dbi = devm_ioremap_resource(&pdev->dev, dbi_base); - if (IS_ERR(pcie->dbi)) + if (IS_ERR(pcie->dbi)) { + dev_err(&pdev->dev, "missing *regs* space\n"); return PTR_ERR(pcie->dbi); + } pcie->scfg = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "fsl,pcie-scfg");
devm_ioremap_resource() validates the resource it receives, so if we check for devm_ioremap_resource() failure, we need not check for failure of the preceding platform_get_resource(). Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/pci/host/pci-layerscape.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html