From patchwork Mon Feb 22 02:06:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28. From: David Miller X-Patchwork-Id: 45966 Message-Id: <20100221.180658.226784107.davem@davemloft.net> To: rob@landley.net Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, blauwirbel@gmail.com, pbonzini@redhat.com, sam@ravnborg.org, atar4qemu@googlemail.com Date: Sun, 21 Feb 2010 18:06:58 -0800 (PST) Here's the fix I'll use, thanks for the report Rob: sparc32: Fix struct stat uid/gid types. Commit 085219f79cad89291699bd2bfb21c9fdabafe65f ("sparc32: use proper types in struct stat") Accidently changed the struct stat uid/gid members to uid_t and gid_t, but those get set to __kernel_uid32_t and __kernel_gid32_t respectively. Those are of type 'int' but the structure is meant to have 'short'. So use uid16_t and gid16_t to correct this. Reported-by: Rob Landley Signed-off-by: David S. Miller --- arch/sparc/include/asm/stat.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sparc/include/asm/stat.h b/arch/sparc/include/asm/stat.h index 55db5ec..39327d6 100644 --- a/arch/sparc/include/asm/stat.h +++ b/arch/sparc/include/asm/stat.h @@ -53,8 +53,8 @@ struct stat { ino_t st_ino; mode_t st_mode; short st_nlink; - uid_t st_uid; - gid_t st_gid; + uid16_t st_uid; + gid16_t st_gid; unsigned short st_rdev; off_t st_size; time_t st_atime;