From patchwork Wed Oct 15 12:31:57 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Vecera X-Patchwork-Id: 4595 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 234A7DDF48 for ; Wed, 15 Oct 2008 23:32:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753576AbYJOMcH (ORCPT ); Wed, 15 Oct 2008 08:32:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752683AbYJOMcF (ORCPT ); Wed, 15 Oct 2008 08:32:05 -0400 Received: from mx2.redhat.com ([66.187.237.31]:61000 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbYJOMcD (ORCPT ); Wed, 15 Oct 2008 08:32:03 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9FCVxwl018158; Wed, 15 Oct 2008 08:31:59 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m9FCVwH3023578; Wed, 15 Oct 2008 08:31:58 -0400 Received: from [10.34.32.90] (ceranb.englab.brq.redhat.com [10.34.32.90]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m9FCVujt024046; Wed, 15 Oct 2008 08:31:57 -0400 Message-ID: <48F5E2BD.8030901@redhat.com> Date: Wed, 15 Oct 2008 14:31:57 +0200 From: Ivan Vecera User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: netdev@vger.kernel.org CC: c4p7n@capitanio.org, Francois Romieu , kernel@vger.kernel.org Subject: Re: [patch] rtl8102e: commit 7bf6bf480 zeroized MAC address References: <200810151011.m9FABBRj025271@post.webmailer.de> In-Reply-To: <200810151011.m9FABBRj025271@post.webmailer.de> X-Enigmail-Version: 0.95.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org c4p7n@capitanio.org wrote: > Tested on top of linus tree and back ported 2.6.27. > > Please cc me, thanks > Martin Capitanio > I think this one is more common. Ivan ===== Subject: [PATCH] [r8169] initialize MAC address found in EEPROM only if is it valid Signed-off-by: Ivan Vecera --- drivers/net/r8169.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index c821da2..587a96c 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1975,8 +1975,9 @@ static void rtl_init_mac_address(struct rtl8169_private *tp, dprintk("MAC address found in EEPROM: %s\n", print_mac(buf, mac)); - /* Write MAC address */ - rtl_rar_set(tp, mac); + /* Write MAC address if is it valid */ + if (is_valid_ether_addr(mac)) + rtl_rar_set(tp, mac); } static int __devinit