Patchwork rtl8102e: commit 7bf6bf480 zeroized MAC address

login
register
mail settings
Submitter Ivan Vecera
Date Oct. 15, 2008, 12:31 p.m.
Message ID <48F5E2BD.8030901@redhat.com>
Download mbox | patch
Permalink /patch/4595/
State Superseded
Delegated to: Jeff Garzik
Headers show

Comments

Ivan Vecera - Oct. 15, 2008, 12:31 p.m.
c4p7n@capitanio.org wrote:
> Tested on top of linus tree and back ported 2.6.27.
> 
> Please cc me, thanks
> Martin Capitanio
> 
I think this one is more common.

Ivan

Patch

=====
Subject: [PATCH] [r8169] initialize MAC address found in EEPROM only if is it valid

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/r8169.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index c821da2..587a96c 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1975,8 +1975,9 @@  static void rtl_init_mac_address(struct rtl8169_private *tp,
 
 	dprintk("MAC address found in EEPROM: %s\n", print_mac(buf, mac));
 
-	/* Write MAC address */
-	rtl_rar_set(tp, mac);
+	/* Write MAC address if is it valid */
+	if (is_valid_ether_addr(mac))
+		rtl_rar_set(tp, mac);
 }
 
 static int __devinit