From patchwork Sun Feb 21 01:01:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 45941 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 03022B7CC2 for ; Sun, 21 Feb 2010 11:52:23 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754863Ab0BUAwV (ORCPT ); Sat, 20 Feb 2010 19:52:21 -0500 Received: from hera.kernel.org ([140.211.167.34]:54858 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755207Ab0BUAwU (ORCPT ); Sat, 20 Feb 2010 19:52:20 -0500 Received: from htj.dyndns.org (localhost [127.0.0.1]) by hera.kernel.org (8.14.3/8.14.3) with ESMTP id o1L0qF9r031744 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 21 Feb 2010 00:52:17 GMT X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.95.2 at hera.kernel.org Received: from [127.0.0.2] (htj.dyndns.org [127.0.0.2]) by htj.dyndns.org (Postfix) with ESMTPSA id 3C85C1005DA2F; Sun, 21 Feb 2010 10:01:28 +0900 (KST) Message-ID: <4B8085E7.5000501@kernel.org> Date: Sun, 21 Feb 2010 10:01:27 +0900 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0 MIME-Version: 1.0 To: =?UTF-8?B?Q2VuZ2l6IEfDvG5heQ==?= CC: Robert Hancock , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" Subject: Re: sata_nv times out for BD-ROM iHOS104-08 References: <4B5666B4.6000804@kernel.org> <51f3faa71001191859l3c323a8ev6b7c0cced2c59e92@mail.gmail.com> <4B5A70E5.6050106@kernel.org> <4B67A149.10406@kernel.org> <4B7C9CEE.4080902@kernel.org> In-Reply-To: X-Enigmail-Version: 1.0 X-Spam-Status: No, score=-0.5 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on hera.kernel.org X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Sun, 21 Feb 2010 00:52:17 +0000 (UTC) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 02/21/2010 04:11 AM, Cengiz Günay wrote: >> Does the attached patch make any difference? > > Not that I can tell. I still get an infinite loop of ata4 errors. I > attached a full dmesg output with the patch. Note that I have both the > patches disable-clear-ua and drain-from-atapi-pio-bytes applied at the > same time. Hmmm... So, DRQ gets cleared? That's strange. When then the 18 extra bytes happen? Can you please try this one? diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c index 0c82d33..ae63b0b 100644 --- a/drivers/ata/sata_nv.c +++ b/drivers/ata/sata_nv.c @@ -585,7 +585,7 @@ static const struct ata_port_info nv_port_info[] = { /* SWNCQ */ { .flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY | - ATA_FLAG_NCQ, + ATA_FLAG_NCQ | ATA_FLAG_PIO_POLLING, .pio_mask = NV_PIO_MASK, .mwdma_mask = NV_MWDMA_MASK, .udma_mask = NV_UDMA_MASK,