Patchwork sata_nv times out for BD-ROM iHOS104-08

login
register
mail settings
Submitter Tejun Heo
Date Feb. 21, 2010, 1:01 a.m.
Message ID <4B8085E7.5000501@kernel.org>
Download mbox | patch
Permalink /patch/45941/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - Feb. 21, 2010, 1:01 a.m.
On 02/21/2010 04:11 AM, Cengiz Günay wrote:
>> Does the attached patch make any difference?
> 
> Not that I can tell. I still get an infinite loop of ata4 errors. I
> attached a full dmesg output with the patch. Note that I have both the
> patches disable-clear-ua and drain-from-atapi-pio-bytes applied at the
> same time.

Hmmm... So, DRQ gets cleared?  That's strange.  When then the 18 extra
bytes happen?  Can you please try this one?
Cengiz Günay - Feb. 21, 2010, 9:28 p.m.
On Sat, Feb 20, 2010 at 8:01 PM, Tejun Heo <tj@kernel.org> wrote:
> Hmmm... So, DRQ gets cleared?  That's strange.  When then the 18 extra
> bytes happen?  Can you please try this one?

It worked!

$ lsscsi
...
[4:0:0:0]    cd/dvd  ATAPI    iHOS104          WL08  /dev/sr0
...

I was able to read a regular DVD in the drive. According to dmesg the
negotiated speed was down to UDMA/33, so I am not sure about the
performance of the drive.

Full dmesg attached.

Thanks!
Cengiz

Patch

diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 0c82d33..ae63b0b 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -585,7 +585,7 @@  static const struct ata_port_info nv_port_info[] = {
 	/* SWNCQ */
 	{
 		.flags	        = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
-				  ATA_FLAG_NCQ,
+				  ATA_FLAG_NCQ | ATA_FLAG_PIO_POLLING,
 		.pio_mask	= NV_PIO_MASK,
 		.mwdma_mask	= NV_MWDMA_MASK,
 		.udma_mask	= NV_UDMA_MASK,