| Message ID | 1428454350-30186-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded |
| Headers | show |
On 08/04/15 02:52, Masahiro Yamada wrote: > "echo" always succeeds, "which g77 || type -p g77 || echo gfortran" > is never run. + mention the correction HOSTLD -> HOSTFC > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 9db52a8..8f4f87c 100644 > --- a/Makefile > +++ b/Makefile > @@ -251,7 +251,7 @@ HOSTRANLIB := ranlib > endif > HOSTAR := $(shell which $(HOSTAR) || type -p $(HOSTAR) || echo ar) > HOSTAS := $(shell which $(HOSTAS) || type -p $(HOSTAS) || echo as) > -HOSTFC := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo || which g77 || type -p g77 || echo gfortran) ^^ Since it was incorrect anyway (it was defined as /usr/bin/ld on the autobuilders) and there was never an issue with it, I guess it was not used anyway. So I propose to completely remove it. Failing that: Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > +HOSTFC := $(shell which $(HOSTFC) || type -p $(HOSTFC) || which g77 || type -p g77 || echo gfortran) > HOSTCPP := $(shell which $(HOSTCPP) || type -p $(HOSTCPP) || echo cpp) > HOSTLD := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo ld) > HOSTLN := $(shell which $(HOSTLN) || type -p $(HOSTLN) || echo ln) >
diff --git a/Makefile b/Makefile index 9db52a8..8f4f87c 100644 --- a/Makefile +++ b/Makefile @@ -251,7 +251,7 @@ HOSTRANLIB := ranlib endif HOSTAR := $(shell which $(HOSTAR) || type -p $(HOSTAR) || echo ar) HOSTAS := $(shell which $(HOSTAS) || type -p $(HOSTAS) || echo as) -HOSTFC := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo || which g77 || type -p g77 || echo gfortran) +HOSTFC := $(shell which $(HOSTFC) || type -p $(HOSTFC) || which g77 || type -p g77 || echo gfortran) HOSTCPP := $(shell which $(HOSTCPP) || type -p $(HOSTCPP) || echo cpp) HOSTLD := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo ld) HOSTLN := $(shell which $(HOSTLN) || type -p $(HOSTLN) || echo ln)
"echo" always succeeds, "which g77 || type -p g77 || echo gfortran" is never run. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)